Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 10441124: Enable the handle verifier. (Closed)

Created:
8 years, 6 months ago by rvargas (doing something else)
Modified:
8 years, 6 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, dcaiafa+watch_chromium.org, wez+watch_chromium.org, erikwright (departed), amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, brettw-cc_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Enable the handle verifier. BUG=127931 TEST=none TBR=willchan, wez, abodenha Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139885

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M base/win/scoped_handle.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/backend/win_helper.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
rvargas (doing something else)
8 years, 6 months ago (2012-05-31 19:49:45 UTC) #1
Wez
alexeypa: PTAL
8 years, 6 months ago (2012-05-31 19:54:09 UTC) #2
alexeypa (please no reviews)
remoting/* - lgtm
8 years, 6 months ago (2012-05-31 19:56:13 UTC) #3
rvargas (doing something else)
On 2012/05/31 19:56:13, alexeypa wrote: > remoting/* - lgtm Thanks. BTW, I'm assuming that the ...
8 years, 6 months ago (2012-05-31 19:59:23 UTC) #4
willchan no longer on Chromium
lgtm On Thu, May 31, 2012 at 12:59 PM, <rvargas@chromium.org> wrote: > On 2012/05/31 19:56:13, ...
8 years, 6 months ago (2012-05-31 20:03:49 UTC) #5
alexeypa (please no reviews)
On 2012/05/31 19:59:23, rvargas wrote: > Thanks. BTW, I'm assuming that the remoting code may ...
8 years, 6 months ago (2012-05-31 20:13:40 UTC) #6
Wez
On 2012/05/31 20:13:40, alexeypa wrote: > On 2012/05/31 19:59:23, rvargas wrote: > > Thanks. BTW, ...
8 years, 6 months ago (2012-05-31 20:18:14 UTC) #7
Albert Bodenhamer
lgtm printing only
8 years, 6 months ago (2012-05-31 20:39:42 UTC) #8
rvargas (doing something else)
8 years, 6 months ago (2012-05-31 22:04:53 UTC) #9
On 2012/05/31 20:18:14, Wez wrote:
> On 2012/05/31 20:13:40, alexeypa wrote:
> > On 2012/05/31 19:59:23, rvargas wrote:
> > > Thanks. BTW, I'm assuming that the remoting code may affect the browser
> > process.
> > > If that's not the case, I can remove it from the CL.
> > 
> > It can affect the browser process if it hosts remoting_host.dll. I.e. a user
> > tried to use Chrome Remote Desktop extension. So basically it is very
> unlikely.
> 
> NPAPI plugins run in their own per-plugin processes, not in the browser
itself.

Removed the remoting code then. (I'm reading this as this code doesn't get
compiled outside an NPAPI plugin).

Thanks.

Powered by Google App Engine
This is Rietveld 408576698