Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 10441122: Roll Skia to r4102. (Closed)

Created:
8 years, 6 months ago by bsalomon
Modified:
8 years, 6 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, darin-cc_chromium.org, skia-review_googlegroups.com, skia-dev_google.com
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M skia/skia.gyp View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/gl/gl_bindings_skia_in_process.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M webkit/glue/gl_bindings_skia_cmd_buffer.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bsalomon
Submitted try jobs for skia roll to 4102.
8 years, 6 months ago (2012-05-31 19:06:16 UTC) #1
epoger
As noted in http://code.google.com/p/skia/wiki/RollDepsInChrome , please CC skia-dev@google.com on Skia deps rolls.
8 years, 6 months ago (2012-05-31 19:44:34 UTC) #2
Tom Hudson
r4104 will also require gyp changes. I suppose I'll kick that try off after this ...
8 years, 6 months ago (2012-05-31 19:49:22 UTC) #3
bsalomon
Adding apatrick@ and jamesr@ for src/webkit/ and src/ui/gl OWNERS reviews. Below is my summary of ...
8 years, 6 months ago (2012-06-01 13:07:00 UTC) #4
reed1
lgtm
8 years, 6 months ago (2012-06-01 16:06:32 UTC) #5
jamesr
webkit/ LGTM
8 years, 6 months ago (2012-06-01 16:49:11 UTC) #6
bsalomon
apatrick@ is OOO today. Could I get a ui/gl thumbs up from gman@ or backer@?
8 years, 6 months ago (2012-06-01 17:36:29 UTC) #7
greggman
8 years, 6 months ago (2012-06-01 17:47:54 UTC) #8
lgtm

Powered by Google App Engine
This is Rietveld 408576698