Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1833)

Unified Diff: runtime/vm/parser.cc

Issue 10441115: Check upper bounds of factory class type parameters when instantiating an (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/co19/co19-runtime.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 8159)
+++ runtime/vm/parser.cc (working copy)
@@ -7904,6 +7904,13 @@
// The type argument vector may have been expanded with the type arguments
// of the super type when finalizing the temporary type.
type_arguments = temp_type.arguments();
+ // The type parameter bounds of the factory class may be more specific than
+ // the type parameter bounds of the interface class. Therefore, although
+ // type was not malformed, temp_type may be malformed.
+ if (!type.IsMalformed() && temp_type.IsMalformed()) {
+ const Error& error = Error::Handle(temp_type.malformed_error());
+ type.set_malformed_error(error);
+ }
}
type_arguments ^= type_arguments.Canonicalize();
« no previous file with comments | « no previous file | tests/co19/co19-runtime.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698