Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: tests/html/typed_arrays_range_checks_test.dart

Issue 10441104: New expectation functions plus convert old tests to use these. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/html/transferables_test.dart ('k') | tests/isolate/mandel_isolate_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/html/typed_arrays_range_checks_test.dart
===================================================================
--- tests/html/typed_arrays_range_checks_test.dart (revision 8345)
+++ tests/html/typed_arrays_range_checks_test.dart (working copy)
@@ -13,13 +13,13 @@
test('outOfRangeAccess_dynamic', () {
var a = new Uint8Array(1024);
- expect(a[a.length]).isNull();
- expect(a[a.length + 1]).isNull();
- expect(a[a.length + 1024]).isNull();
+ expect(a[a.length], isNull);
+ expect(a[a.length + 1], isNull);
+ expect(a[a.length + 1024], isNull);
- // expect(a[-1]).isNull();
- // expect(a[-2]).isNull();
- // expect(a[-1024]).isNull();
+ // expect(a[-1], isNull);
+ // expect(a[-2], isNull);
+ // expect(a[-1024], isNull);
// It's harder to test out of range setters, but let's do some minimum.
a[a.length] = 0xdeadbeaf;
@@ -34,13 +34,13 @@
test('outOfRange_typed', () {
Uint8Array a = new Uint8Array(1024);
- expect(a[a.length]).isNull();
- expect(a[a.length + 1]).isNull();
- expect(a[a.length + 1024]).isNull();
+ expect(a[a.length], isNull);
+ expect(a[a.length + 1], isNull);
+ expect(a[a.length + 1024], isNull);
- // expect(a[-1]).isNull();
- // expect(a[-2]).isNull();
- // expect(a[-1024]).isNull();
+ // expect(a[-1], isNull);
+ // expect(a[-2], isNull);
+ // expect(a[-1024], isNull);
// It's harder to test out of range setters, but let's do some minimum.
a[a.length] = 0xdeadbeaf;
« no previous file with comments | « tests/html/transferables_test.dart ('k') | tests/isolate/mandel_isolate_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698