Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: samples/tests/samples/lib/view/view_test.dart

Issue 10441104: New expectation functions plus convert old tests to use these. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « samples/tests/samples/lib/util/util_test.dart ('k') | tests/dom/canvas_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: samples/tests/samples/lib/view/view_test.dart
===================================================================
--- samples/tests/samples/lib/view/view_test.dart (revision 8345)
+++ samples/tests/samples/lib/view/view_test.dart (working copy)
@@ -14,17 +14,17 @@
useHtmlConfiguration();
test('does not render immediately', () {
final view = new TestView();
- expect(view.isRendered).isFalse();
+ expect(view.isRendered, isFalse);
view.addToDocument(document.body);
- expect(view.isRendered).isTrue();
+ expect(view.isRendered, isTrue);
});
group('addToDocument()', () {
test('causes view to render', () {
final view = new TestView();
view.addToDocument(document.body);
- expect(view.isRendered).isTrue();
+ expect(view.isRendered, isTrue);
});
test('calls afterRender()', () {
@@ -39,7 +39,7 @@
view.addToDocument(document.body);
- expect(result).equals('renderafter');
+ expect(result, equals('renderafter'));
});
test('calls enterDocument()', () {
@@ -48,7 +48,7 @@
view.enterDocumentFn = () { entered = true; };
view.addToDocument(document.body);
- expect(entered).isTrue();
+ expect(entered, isTrue);
});
});
@@ -57,7 +57,7 @@
final rendered = new Element.html('<div class="node"></div>');
final view = new TestView();
view.renderFn = () => rendered;
- view.afterRenderFn = (node) { expect(node).equals(rendered); };
+ view.afterRenderFn = (node) { expect(node, equals(rendered)); };
view.addToDocument(document.body);
});
@@ -76,7 +76,7 @@
parent.childViews = [child];
parent.childViewAdded(child);
- expect(entered).isTrue();
+ expect(entered, isTrue);
});
test('does not call enterDocument() if parent is not in document', () {
@@ -90,7 +90,7 @@
parent.childViews = [child];
parent.childViewAdded(child);
- expect(entered).isFalse();
+ expect(entered, isFalse);
});
test('calls enterDocument() each time added', () {
@@ -110,7 +110,7 @@
parent.childViewAdded(child);
parent.childViewRemoved(child);
- expect(entered).equals(3);
+ expect(entered, equals(3));
});
});
@@ -127,7 +127,7 @@
parent.childViews = [];
parent.childViewRemoved(child);
- expect(exited).isTrue();
+ expect(exited, isTrue);
});
test('does not call exitDocument() if parent is not in document', () {
@@ -141,7 +141,7 @@
parent.childViews = [];
parent.childViewRemoved(child);
- expect(exited).isFalse();
+ expect(exited, isFalse);
});
test('calls exitDocument() each time removed', () {
@@ -161,7 +161,7 @@
parent.childViewAdded(child);
parent.childViewRemoved(child);
- expect(exited).equals(3);
+ expect(exited, equals(3));
});
});
@@ -178,7 +178,7 @@
parent.childViews = [child];
parent.addToDocument(document.body);
- expect(result).equals('childparent');
+ expect(result, equals('childparent'));
});
});
}
« no previous file with comments | « samples/tests/samples/lib/util/util_test.dart ('k') | tests/dom/canvas_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698