Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: samples/tests/samples/lib/observable/abstract_observable_tests.dart

Issue 10441104: New expectation functions plus convert old tests to use these. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/unittest/unittest.dart ('k') | samples/tests/samples/lib/observable/event_batch_tests.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: samples/tests/samples/lib/observable/abstract_observable_tests.dart
===================================================================
--- samples/tests/samples/lib/observable/abstract_observable_tests.dart (revision 8345)
+++ samples/tests/samples/lib/observable/abstract_observable_tests.dart (working copy)
@@ -8,8 +8,8 @@
final target = new AbstractObservable();
final listener = (e) { };
- expect(target.addChangeListener(listener)).isTrue();
- expect(target.addChangeListener(listener)).isFalse();
+ expect(target.addChangeListener(listener), isTrue);
+ expect(target.addChangeListener(listener), isFalse);
});
test('modifies listeners list', () {
@@ -20,29 +20,29 @@
final l3 = (e) { };
final l4 = (e) { };
- expect(target.listeners).equalsCollection([]);
+ expect(target.listeners, orderedEquals([]));
target.addChangeListener(l1);
- expect(target.listeners).equalsCollection([l1]);
+ expect(target.listeners, orderedEquals([l1]));
target.addChangeListener(l2);
- expect(target.listeners).equalsCollection([l1, l2]);
+ expect(target.listeners, orderedEquals([l1, l2]));
target.addChangeListener(l3);
target.addChangeListener(l4);
- expect(target.listeners).equalsCollection([l1, l2, l3, l4]);
+ expect(target.listeners, orderedEquals([l1, l2, l3, l4]));
target.removeChangeListener(l4);
- expect(target.listeners).equalsCollection([l1, l2, l3]);
+ expect(target.listeners, orderedEquals([l1, l2, l3]));
target.removeChangeListener(l2);
- expect(target.listeners).equalsCollection([l1, l3]);
+ expect(target.listeners, orderedEquals([l1, l3]));
target.removeChangeListener(l1);
- expect(target.listeners).equalsCollection([l3]);
+ expect(target.listeners, orderedEquals([l3]));
target.removeChangeListener(l3);
- expect(target.listeners).equalsCollection([]);
+ expect(target.listeners, orderedEquals([]));
});
});
@@ -52,22 +52,22 @@
final target = new AbstractObservable();
EventSummary res = null;
target.addChangeListener((summary) {
- expect(res).isNull();
+ expect(res, isNull);
res = summary;
- expect(res).isNotNull();
+ expect(res, isNotNull);
});
target.recordPropertyUpdate('pM', 10, 11);
- expect(res).isNotNull();
- expect(res.events.length).equals(1);
+ expect(res, isNotNull);
+ expect(res.events, hasLength(1));
validateUpdate(res.events[0], target, 'pM', null, 10, 11);
res = null;
target.recordPropertyUpdate('pL', '11', '13');
- expect(res).isNotNull();
- expect(res.events.length).equals(1);
+ expect(res, isNotNull);
+ expect(res.events, hasLength(1));
validateUpdate(res.events[0], target, 'pL', null, '11', '13');
});
}
« no previous file with comments | « lib/unittest/unittest.dart ('k') | samples/tests/samples/lib/observable/event_batch_tests.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698