Issue 10441091: Fix broken change to d8 typed arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10441091: Fix broken change to d8 typed arrays. (Closed)

Created:
8 years, 6 months ago by rossberg

Modified:
8 years, 6 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix broken change to d8 typed arrays. R=mstarzinger@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11680

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	src/d8.cc	View		4 chunks	+8 lines, -5 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 6 months ago (2012-05-30 14:25:08 UTC) #2

LGTM. Just one nit, but feel free to move that over to one of your follow-up
CLs.

https://chromiumcodereview.appspot.com/10441091/diff/1/src/d8.cc
File src/d8.cc (right):

https://chromiumcodereview.appspot.com/10441091/diff/1/src/d8.cc#newcode378
src/d8.cc:378: String::New("byteOffset out of bounds"));
That should fit into one line.

Expand Messages | Collapse Messages