Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Issue 10441088: Implement grokdump annotations for well-known objects. (Closed)

Created:
8 years, 6 months ago by Michael Starzinger
Modified:
8 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Implement grokdump annotations for well-known objects. R=ulan@chromium.org TEST=tools/grokdump.py Committed: https://code.google.com/p/v8/source/detail?r=11684

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment by Erik Corry. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+445 lines, -57 lines) Patch
M tools/grokdump.py View 1 13 chunks +445 lines, -57 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Michael Starzinger
8 years, 6 months ago (2012-05-30 09:17:48 UTC) #1
Erik Corry
https://chromiumcodereview.appspot.com/10441088/diff/1/tools/grokdump.py File tools/grokdump.py (right): https://chromiumcodereview.appspot.com/10441088/diff/1/tools/grokdump.py#newcode465 tools/grokdump.py:465: print >>sys.stderr, "WARNING: This is NOT a full minidump!" ...
8 years, 6 months ago (2012-05-30 13:06:12 UTC) #2
Michael Starzinger
Addressed comments. https://chromiumcodereview.appspot.com/10441088/diff/1/tools/grokdump.py File tools/grokdump.py (right): https://chromiumcodereview.appspot.com/10441088/diff/1/tools/grokdump.py#newcode465 tools/grokdump.py:465: print >>sys.stderr, "WARNING: This is NOT a ...
8 years, 6 months ago (2012-05-30 13:14:06 UTC) #3
ulan
Cool stuff, LGTM.
8 years, 6 months ago (2012-05-31 07:54:51 UTC) #4
Vitaly Repeshko
Nice to see this evolving. Drive-by comment. https://chromiumcodereview.appspot.com/10441088/diff/4001/tools/grokdump.py File tools/grokdump.py (right): https://chromiumcodereview.appspot.com/10441088/diff/4001/tools/grokdump.py#newcode741 tools/grokdump.py:741: # #define ...
8 years, 6 months ago (2012-05-31 17:34:19 UTC) #5
Michael Starzinger
8 years, 6 months ago (2012-06-01 09:13:05 UTC) #6
I would love to get to a point were I don't need to use WinDbg anymore.

https://chromiumcodereview.appspot.com/10441088/diff/4001/tools/grokdump.py
File tools/grokdump.py (right):

https://chromiumcodereview.appspot.com/10441088/diff/4001/tools/grokdump.py#n...
tools/grokdump.py:741: # #define ROOT_LIST_CASE(type, name, camel_name) \
On 2012/05/31 17:34:20, Vitaly Repeshko wrote:
> Updating this stuff is going to be even more painful now. Consider creating a
> separate V8 build target to print this info.

Yes, I totally agree. At some point the build system should dump the necessary
information in a separate .py file, that we then can include into grokdump.

Powered by Google App Engine
This is Rietveld 408576698