runtime/bin/socket_impl.dart - Issue 10441078: Add test that passes invalid arguments to socket methods and fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/socket_impl.dart

Issue 10441078: Add test that passes invalid arguments to socket methods and fix (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/socket_impl.dart

diff --git a/runtime/bin/socket_impl.dart b/runtime/bin/socket_impl.dart

index 419db47acd15fbd9280f9499b1f5e4426d3a2e86..702c2dfa30cfe37becaa70f69f9472a0bc681bf9 100644

--- a/runtime/bin/socket_impl.dart

+++ b/runtime/bin/socket_impl.dart

@@ -225,7 +225,7 @@ class _SocketBase {

int hashCode() => _hashCode;

- bool _propagateError(Exception e) => null;

+ bool _propagateError(Exception e) => false;

abstract bool _isListenSocket();

abstract bool _isPipe();

« runtime/bin/socket.cc ('K') | « runtime/bin/socket.cc ('k') | tests/standalone/io/socket_invalid_arguments_test.dart » ('j') | tests/standalone/standalone.status » ('J')