Issue 10441057: Issue 3248. Fix for extra interface final field warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10441057: Issue 3248. Fix for extra interface final field warnings (Closed)

Created:
8 years, 7 months ago by scheglov

Modified:
8 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Issue 3248. Fix for extra interface final field warnings http://code.google.com/p/dart/issues/detail?id=3248 I can not find any proof in spec that interface fields are always final. In contrast, I see that dart:html explicitly marks some fields as final. R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8065

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -3 lines)			Patch
	M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Brian Wilkerson

8 years, 6 months ago (2012-05-26 17:15:10 UTC) #2

Agreed. The specification specifically defines the semantics of non-final fields
in interfaces. LGTM.