Refactor common logic of SsaBuilder.visitSend.

lib/compiler/implementation/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Interceptors {
   Compiler compiler;
   Interceptors(Compiler this.compiler);
 
   SourceString mapOperatorToMethodName(Operator op) {
     String name = op.source.stringValue;
@@ skipping 767 matching lines @@
   List<LabelElement> labels() {
     List<LabelElement> result = null;
     for (LabelElement element in target.labels) {
       if (result === null) result = <LabelElement>[];
       result.add(element);
     }
     return (result === null) ? const <LabelElement>[] : result;
   }
 }
 
-class SsaBuilder implements Visitor {
+class SsaBuilder extends ResolvedVisitor implements Visitor {
   final SsaBuilderTask builder;
-  TreeElements elements;
   final Interceptors interceptors;
   final WorkItem work;
   bool methodInterceptionEnabled;
   HGraph graph;
   LocalsHandler localsHandler;
   HInstruction rethrowableException;
 
   Map<TargetElement, JumpHandler> jumpTargets;
 
   /**
@@ skipping 16 matching lines @@
 
   LibraryElement get currentLibrary() => work.element.getLibrary();
   Compiler get compiler() => builder.compiler;
   CodeEmitterTask get emitter() => builder.emitter;
 
   SsaBuilder(SsaBuilderTask builder, WorkItem work)
     : this.builder = builder,
       this.work = work,
       interceptors = builder.interceptors,
       methodInterceptionEnabled = true,
-      elements = work.resolutionTree,
       graph = new HGraph(),
       stack = new List<HInstruction>(),
       activationVariables = new Map<Element, HParameterValue>(),
-      jumpTargets = new Map<TargetElement, JumpHandler>() {
+      jumpTargets = new Map<TargetElement, JumpHandler>(),
+      super(work.resolutionTree) {
     localsHandler = new LocalsHandler(this);
   }
 
   void disableMethodInterception() {
     assert(methodInterceptionEnabled);
     methodInterceptionEnabled = false;
   }
 
   void enableMethodInterception() {
     assert(!methodInterceptionEnabled);
@@ skipping 1055 matching lines @@
       if (checked !== value) {
         pop();
         stack.add(checked);
       }
       localsHandler.updateLocal(element, checked);
     }
   }
 
   visitOperatorSend(node) {
     assert(node.selector is Operator);
+    if (!methodInterceptionEnabled) {
+      visitDynamicSend(node);
+      return;
+    }
+
     Operator op = node.selector;
     if (const SourceString("[]") == op.source) {
       HStatic target = new HStatic(interceptors.getIndexInterceptor());
       add(target);
       visit(node.receiver);
       HInstruction receiver = pop();
       visit(node.argumentsNode);
       HInstruction index = pop();
       push(new HIndex(target, receiver, index));
     } else if (const SourceString("&&") == op.source ||
@@ skipping 322 matching lines @@
     visit(closure);
     List<HInstruction> inputs = <HInstruction>[pop()];
     String invocationName = compiler.namer.closureInvocationName(
         new Selector(SelectorKind.INVOCATION,
                      parameters.requiredParameterCount));
     push(new HForeign(new DartString.literal('#.$invocationName'),
                       const LiteralDartString('var'),
                       inputs));
   }
 
-  handleForeignSend(Send node) {
+  visitForeignSend(Send node) {
     Element element = elements[node];
     if (element.name == const SourceString('JS')) {
       handleForeignJs(node);
     } else if (element.name == const SourceString('UNINTERCEPTED')) {
       handleForeignUnintercepted(node);
     } else if (element.name == const SourceString('JS_HAS_EQUALS')) {
       handleForeignJsHasEquals(node);
     } else if (element.name == const SourceString('JS_CURRENT_ISOLATE')) {
       handleForeignJsCurrentIsolate(node);
     } else if (element.name == const SourceString('JS_CALL_IN_ISOLATE')) {
@@ skipping 134 matching lines @@
       if (element.kind == ElementKind.GETTER) {
         target = new HInvokeStatic(Selector.GETTER, inputs);
         add(target);
         inputs = <HInstruction>[target];
       }
       addDynamicSendArgumentsToList(node, inputs);
       push(new HInvokeClosure(selector, inputs));
     }
   }
 
-  visitSend(Send node) {
-    if (node.isSuperCall) {
-      visitSuperSend(node);
-    } else if (node.isOperator && methodInterceptionEnabled) {
-      visitOperatorSend(node);
-    } else if (node.isPropertyAccess) {
-      generateGetter(node, elements[node]);
-    } else if (Elements.isClosureSend(node, elements)) {
-      visitClosureSend(node);
-    } else {
-      Element element = elements[node];
-      if (element === null) {
-        // Example: f() with 'f' unbound.
-        // This can only happen inside an instance method.
-        visitDynamicSend(node);
-      } else if (element.kind == ElementKind.CLASS) {
-        compiler.internalError("Cannot generate code for send", node: node);
-      } else if (element.isInstanceMember()) {
-        // Example: f() with 'f' bound to instance method.
-        visitDynamicSend(node);
-      } else if (element.kind === ElementKind.FOREIGN) {
-        handleForeignSend(node);
-      } else if (!element.isInstanceMember()) {
-        // Example: A.f() or f() with 'f' bound to a static function.
-        // Also includes new A() or new A.named() which is treated like a
-        // static call to a factory.
-        visitStaticSend(node);
-      } else {
-        compiler.internalError("Cannot generate code for send", node: node);
-      }
-    }
+  visitGetterSend(Send node) {
+    generateGetter(node, elements[node]);
+  }
+
+  // TODO(antonm): migrate rest of SsaBuilder to internalError.
+  internalError(String reason, [Node node]) {
+    compiler.internalError(reason, node: node);
   }
 
   // TODO(karlklose): share with resolver.
   TypeAnnotation getTypeAnnotationFromSend(Send send) {
     if (send.selector is TypeAnnotation) {
       return send.selector;
     } else if (send.selector is Send) {
       Send selector = send.selector;
       if (selector.receiver is TypeAnnotation) {
         return selector.receiver;
@@ skipping 968 matching lines @@
                                    <HInstruction>[target, input],
                                    HType.STRING));
     return builder.pop();
   }
 
   HInstruction result(Node node) {
     flushLiterals(node);
     return prefix;
   }
 }