Refactor common logic of SsaBuilder.visitSend.

lib/compiler/implementation/tree/nodes.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface Visitor<R> {
   R visitBlock(Block node);
   R visitBreakStatement(BreakStatement node);
   R visitCascade(Cascade node);
   R visitCascadeReceiver(CascadeReceiver node);
   R visitCaseMatch(CaseMatch node);
@@ skipping 275 matching lines @@
       return argumentsNode.getEndToken();
     }
     if (selector !== null) return selector.getEndToken();
     return receiver.getBeginToken();
   }
 
   Send copyWithReceiver(Node newReceiver) {
     assert(receiver === null);
     return new Send(newReceiver, selector, argumentsNode);
   }
+
+  analyse([

[ahe, 2012/05/29 10:24:00]

It concerns that I don't see how this can avoid creating a whole bunch of
objects (closures). You cannot afford that, we do it anyways in a lot of cases,
but API like this (if feasible) should be designed to avoid creating objects.
Based on my experience in a similar compiler, I believe that keeping a lid on
the number of little objects created is key to performance.

I have an alternative suggestion.

Create an interface like this:

interface ResolvedSendVisitor<R> extends Visitor<R> {
  R visitSuperRead(Send node);
  R visitSuperSend(Send node);
  R visitOperatorSend(Send node);
  ...
}

And this method should be called 'resolvedAccept' or something similar.

[Anton Muhin, 2012/05/31 18:56:38]

Done.

+      bool methodInterceptionEnabled,
+      TreeElements elements,
+      superRead(Send node),
+      superSend(Send node),
+      operatorSend(Send node),
+      getterSend(Send node),
+      closureSend(Send node),
+      dynamicSend(Send node),
+      foreignSend(Send node),
+      staticSend(Send node),
+      internalError(String reason)]) {
+    if (isSuperCall) {
+      if (isPropertyAccess) {
+        return superRead(this);
+      } else {
+        return superSend(this);
+      }
+    } else if (isOperator && methodInterceptionEnabled) {
+      return operatorSend(this);
+    } else if (isPropertyAccess) {
+      return getterSend(this);
+    } else if (Elements.isClosureSend(this, elements)) {
+      return closureSend(this);
+    } else {
+      Element element = elements[this];
+      if (element === null) {
+        // Example: f() with 'f' unbound.
+        // This can only happen inside an instance method.
+        return dynamicSend(this);
+      } else if (element.kind == ElementKind.CLASS) {
+        internalError("Cannot generate code for send");
+      } else if (element.isInstanceMember()) {
+        // Example: f() with 'f' bound to instance method.
+        return dynamicSend(this);
+      } else if (element.kind === ElementKind.FOREIGN) {
+        return foreignSend(this);
+      } else if (!element.isInstanceMember()) {
+        // Example: A.f() or f() with 'f' bound to a static function.
+        // Also includes new A() or new A.named() which is treated like a
+        // static call to a factory.
+        return staticSend(this);
+      } else {
+        internalError("Cannot generate code for send");
+      }
+    }
+  }
 }
 
 class Postfix extends NodeList {
   Postfix() : super(nodes: const EmptyLink<Node>());
   Postfix.singleton(Node argument) : super.singleton(argument);
 }
 
 class Prefix extends NodeList {
   Prefix() : super(nodes: const EmptyLink<Node>());
   Prefix.singleton(Node argument) : super.singleton(argument);
@@ skipping 1394 matching lines @@
  * argument).
  *
  * TODO(ahe): This method is controversial, the team needs to discuss
  * if top-level methods are acceptable and what naming conventions to
  * use.
  */
 initializerDo(Node node, f(Node node)) {
   SendSet send = node.asSendSet();
   if (send !== null) return f(send.arguments.head);
 }