Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 10441019: Move render_view_host_delegate.h out of content/public. (Closed)

Created:
8 years, 7 months ago by jam
Modified:
8 years, 7 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jochen+watch-content_chromium.org, jam, penghuang+watch_chromium.org, dcheng, joi+watch-content_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, James Su
Visibility:
Public.

Description

Move render_view_host_delegate.h out of content/public. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138812

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -457 lines) Patch
M chrome/test/base/ui_test_utils.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/download/save_package.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/cross_site_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
A + content/browser/renderer_host/render_view_host_delegate.h View 3 chunks +3 lines, -5 lines 0 comments Download
A + content/browser/renderer_host/render_view_host_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/transfer_navigation_resource_throttle.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/interstitial_page_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/render_view_host_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/render_view_host_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_drag_source_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
D content/public/browser/render_view_host_delegate.h View 1 chunk +0 lines, -392 lines 0 comments Download
D content/public/browser/render_view_host_delegate.cc View 1 chunk +0 lines, -41 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
8 years, 7 months ago (2012-05-24 15:41:10 UTC) #1
Jói
LGTM!
8 years, 7 months ago (2012-05-24 16:09:57 UTC) #2
Ben Goodger (Google)
OK so this CL is stopping me from going from a RVH to a WC. ...
8 years, 7 months ago (2012-05-24 18:21:17 UTC) #3
Ben Goodger (Google)
8 years, 7 months ago (2012-05-24 18:23:19 UTC) #4
Aha, I see WebContents::FromRenderViewHost.

nm!

-Ben

On Thu, May 24, 2012 at 11:21 AM, Ben Goodger (Google) <ben@chromium.org>wrote:

> OK so this CL is stopping me from going from a RVH to a WC. I tried to
> land my change earlier I received this as a merge conflict.
>
> What is the approved way to go from a RVH to a WC?
>
> -Ben
>
>
> On Thu, May 24, 2012 at 8:41 AM, <jam@chromium.org> wrote:
>
>> Reviewers: Jói,
>>
>> Description:
>> Move render_view_host_delegate.h out of content/public.
>>
>> BUG=98716
>>
>> Please review this at
http://codereview.chromium.**org/10441019/<http://codereview.chromium.org/104...
>>
>> SVN Base: svn://chrome-svn/chrome/trunk/**src/
>>
>> Affected files:
>>  M     chrome/test/base/ui_test_**utils.cc
>>  M     content/browser/download/save_**package.cc
>>  M     content/browser/renderer_host/**cross_site_resource_handler.cc
>>  M     content/browser/renderer_host/**render_message_filter.cc
>>  M     content/browser/renderer_host/**render_process_host_impl.cc
>>  A  +  content/browser/renderer_host/**render_view_host_delegate.h
>>  A  +  content/browser/renderer_host/**render_view_host_delegate.cc
>>  M     content/browser/renderer_host/**render_view_host_impl.cc
>>  M     content/browser/renderer_host/**render_widget_host_view_gtk.cc
>>  M     content/browser/renderer_host/**resource_dispatcher_host_impl.**cc
>>  M     content/browser/renderer_host/**transfer_navigation_resource_**
>> throttle.cc
>>  M     content/browser/web_contents/**interstitial_page_impl.h
>>  M     content/browser/web_contents/**render_view_host_manager.h
>>  M     content/browser/web_contents/**render_view_host_manager.cc
>>  M     content/browser/web_contents/**web_contents_impl.h
>>  M     content/browser/web_contents/**web_drag_source_gtk.cc
>>  M     content/browser/worker_host/**worker_process_host.cc
>>  M     content/content_browser.gypi
>>  D     content/public/browser/render_**view_host_delegate.h
>>  D     content/public/browser/render_**view_host_delegate.cc
>>
>>
>>
>

Powered by Google App Engine
This is Rietveld 408576698