Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 10441017: Add an OWNERS file for chrome/renderer/prerender. (Closed)

Created:
8 years, 7 months ago by gavinp
Modified:
8 years, 7 months ago
Reviewers:
cbentzel, dominich, jam, mmenke
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org, scherkus (not reviewing), James Simonsen
Visibility:
Public.

Description

Add an OWNERS file for chrome/renderer/prerender. There's enough renderer-side for Prerendering that we should make sure there's prerender reviewer coverage for changes there. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139126

Patch Set 1 #

Patch Set 2 : -shishir #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
A chrome/renderer/prerender/OWNERS View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
gavinp
jam, I believe you asked for this a few weeks ago. Well, I've done it. ...
8 years, 7 months ago (2012-05-24 14:23:37 UTC) #1
mmenke
Seems the right set to me, LGTM. Though I think you mean "The condemned" or ...
8 years, 7 months ago (2012-05-24 14:27:58 UTC) #2
dominich
LGTM
8 years, 7 months ago (2012-05-24 14:46:48 UTC) #3
jam
lgtm
8 years, 7 months ago (2012-05-24 15:07:26 UTC) #4
Shishir
On 2012/05/24 15:07:26, John Abd-El-Malek wrote: > lgtm Can't add me since I am not ...
8 years, 7 months ago (2012-05-24 18:19:57 UTC) #5
gavinp
Thanks Shishir for pointing that out. cbentzel, do you want to look at this?
8 years, 7 months ago (2012-05-25 16:59:10 UTC) #6
cbentzel
I did, seemed fine. LGTM On Fri, May 25, 2012 at 12:59 PM, <gavinp@chromium.org> wrote: ...
8 years, 7 months ago (2012-05-25 17:30:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/10441017/5001
8 years, 7 months ago (2012-05-25 17:47:59 UTC) #8
commit-bot: I haz the power
Try job failure for 10441017-5001 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-25 18:33:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/10441017/5001
8 years, 7 months ago (2012-05-25 19:10:35 UTC) #10
commit-bot: I haz the power
8 years, 7 months ago (2012-05-25 21:42:57 UTC) #11
Change committed as 139126

Powered by Google App Engine
This is Rietveld 408576698