Issue 10441016: Add FileUtilities::GetFileInfo() to capture file metadata with single IPC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10441016: Add FileUtilities::GetFileInfo() to capture file metadata with single IPC (Closed)

Created:
8 years, 7 months ago by kinuko

Modified:
8 years, 7 months ago

Reviewers:
tony, Avi (use Gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jam, jochen+watch-content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Add FileUtilities::GetFileInfo() to capture file metadata with single IPC Corresponding webkit change: https://bugs.webkit.org/show_bug.cgi?id=86995 The plan includes eventually deprecating two separate IPC calls GetFileSize() and GetFileModificationTime() in favor of GetFileInfo(). BUG=none TEST=existing tests should pass Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139022

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+105 lines, -8 lines)			Patch
M	content/browser/renderer_host/file_utilities_message_filter.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/file_utilities_message_filter.cc	View	2 chunks	+19 lines, -0 lines	0 comments	Download
M	content/common/file_utilities_messages.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/common/fileapi/webfilesystem_callback_dispatcher.cc	View	1 chunk	+2 lines, -8 lines	0 comments	Download
M	content/renderer/renderer_webkitplatformsupport_impl.cc	View	4 chunks	+18 lines, -0 lines	0 comments	Download
M	content/worker/worker_webkitplatformsupport_impl.cc	View	5 chunks	+19 lines, -0 lines	0 comments	Download
M	webkit/glue/webfileutilities_impl.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	webkit/glue/webfileutilities_impl.cc	View	2 chunks	+16 lines, -0 lines	0 comments	Download
M	webkit/glue/webkit_glue.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	webkit/glue/webkit_glue.cc	View	2 chunks	+13 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

kinuko

This patch is to introduce FileUtilities::GetFileInfo() mainly for File related cleanup. Could you take a ...

8 years, 7 months ago (2012-05-24 12:55:39 UTC) #1

lgtm2