Adding unary op optimizations. missing assembly operations/

runtime/vm/intermediate_language_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "lib/error.h"
 #include "vm/flow_graph_compiler.h"
 #include "vm/locations.h"
@@ skipping 1175 matching lines @@
   Register right = locs()->in(1).reg();
   __ pushq(left);
   __ pushq(right);
   InstanceCallComp* instance_call_comp = instance_call();
   instance_call_comp->EmitNativeCode(compiler);
   if (locs()->out().reg() != RAX) {
     __ movq(locs()->out().reg(), RAX);
   }
 }
 
+
+LocationSummary* UnaryOpComp::MakeLocationSummary() const {
+  const intptr_t kNumInputs = 1;
+  const intptr_t kNumTemps = 1;  // Needed for doubles.
+  LocationSummary* summary = new LocationSummary(kNumInputs, kNumTemps);
+  summary->set_in(0, Location::RequiresRegister());
+  summary->set_out(Location::SameAsFirstInput());
+  summary->set_temp(0, Location::RequiresRegister());
+  return summary;
+}
+
+
+void UnaryOpComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  const ICData& ic_data = *instance_call()->ic_data();
+  ASSERT(!ic_data.IsNull());
+  ASSERT(ic_data.num_args_tested() == 1);
+  // TODO(srdjan): Implement for more checks.
+  ASSERT(ic_data.NumberOfChecks() == 1);
+  Class& test_class = Class::Handle();
+  Function& target = Function::Handle();
+  ic_data.GetOneClassCheckAt(0, &test_class, &target);
+
+  Register value = locs()->in(0).reg();
+  Register result = locs()->out().reg();
+  ASSERT(value == result);
+  Label* deopt = compiler->AddDeoptStub(instance_call()->cid(),
+                                        instance_call()->token_index(),
+                                        instance_call()->try_index(),
+                                        kDeoptSmiBinaryOp,
+                                        value,
+                                        kNoRegister);
+  if (test_class.index() == kSmi) {
+    __ testq(value, Immediate(kSmiTagMask));
+    __ j(NOT_ZERO, deopt);
+    switch (op_kind()) {
+      case Token::kNEGATE:
+        __ negq(value);
+        __ j(OVERFLOW, deopt);
+        break;
+      case Token::kBIT_NOT:
+        __ notq(value);
+        __ andq(value, Immediate(~kSmiTagMask));  // Remove inverted smi-tag.
+        break;
+      default:
+        UNREACHABLE();
+    }
+    return;
+  }
+  if (test_class.index() == kDouble) {

[Florian Schneider, 2012/05/31 09:22:54]

Maybe it would make sense to split UnaryOp into two: UnarySmiOp and
UnaryDoubleOp. This way the instruction template gets shorter and you can
specify the precise number of registers needed for each: 1 temp for the double
case, 0 temps for the smi-case.

[srdjan, 2012/05/31 20:02:44]

UnaryOpComp -> UnarySmiOpComp  and adding NumberNegateComp which should also
handle mixed int/double receivers (differentiate it from existing
BooleanNegateComp)

+    if (op_kind() == Token::kBIT_NOT) {
+      __ jmp(deopt);
+      return;
+    }
+    Register temp = locs()->temp(0).reg();
+    __ testq(value, Immediate(kSmiTagMask));
+    __ j(ZERO, deopt);  // Smi.
+    __ CompareClassId(value, kDouble);
+    __ j(NOT_EQUAL, deopt);
+    ASSERT(op_kind() == Token::kNEGATE);
+    // Allocate result object.
+    const Class& double_class =
+      Class::ZoneHandle(Isolate::Current()->object_store()->double_class());
+    const Code& stub =
+        Code::Handle(StubCode::GetAllocationStubForClass(double_class));
+    const ExternalLabel label(double_class.ToCString(), stub.EntryPoint());
+    __ pushq(value);
+    compiler->GenerateCall(instance_call()->token_index(),
+                           instance_call()->try_index(),
+                           &label,
+                           PcDescriptors::kOther);
+    // Result is in EAX.
+    __ movq(result, RAX);
+    __ popq(temp);
+    __ movsd(XMM0, FieldAddress(temp, Double::value_offset()));
+    __ DoubleNegate(XMM0);
+    __ movsd(FieldAddress(result, Double::value_offset()), XMM0);
+  }
+}
+
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64