chrome/browser/ui/website_settings/OWNERS - Issue 10440092: Remove any platform specific code from the chrome/browser/website_settings.* .

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/website_settings/OWNERS

Issue 10440092: Remove any platform specific code from the chrome/browser/website_settings.* . (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/ui/gtk/website_settings_popup_gtk.cc ('K') | « chrome/browser/ui/gtk/website_settings_popup_gtk.cc ('k') | chrome/browser/ui/website_settings/website_settings.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 set noparent
	tfarina 2012/06/01 21:20:26 There was a thread on chromium-dev about this. I n There was a thread on chromium-dev about this. I need to check, I'm not sure if we should or not keep using "set noparent" anymore. markusheintz_ 2012/06/02 21:22:33 I vaguely remember a thread but not the result. I Show quoted text On 2012/06/01 21:20:26, tfarina wrote: > There was a thread on chromium-dev about this. I need to check, I'm not sure if > we should or not keep using "set noparent" anymore. I vaguely remember a thread but not the result. I guess I can easily add it later. Personally I find the set noparent very usefull since it enforces OWNER LGTM. In emergency situation people can always commit as TBR.
	2 markusheintz@chromium.org

OLD	NEW