Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: chrome/browser/ui/gtk/browser_window_gtk.cc

Issue 10440092: Remove any platform specific code from the chrome/browser/website_settings.* . (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/gtk/browser_window_gtk.h" 5 #include "chrome/browser/ui/gtk/browser_window_gtk.h"
6 6
7 #include <dlfcn.h> 7 #include <dlfcn.h>
8 #include <gdk/gdkkeysyms.h> 8 #include <gdk/gdkkeysyms.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 #include "chrome/browser/ui/gtk/location_bar_view_gtk.h" 63 #include "chrome/browser/ui/gtk/location_bar_view_gtk.h"
64 #include "chrome/browser/ui/gtk/nine_box.h" 64 #include "chrome/browser/ui/gtk/nine_box.h"
65 #include "chrome/browser/ui/gtk/one_click_signin_bubble_gtk.h" 65 #include "chrome/browser/ui/gtk/one_click_signin_bubble_gtk.h"
66 #include "chrome/browser/ui/gtk/password_generation_bubble_gtk.h" 66 #include "chrome/browser/ui/gtk/password_generation_bubble_gtk.h"
67 #include "chrome/browser/ui/gtk/reload_button_gtk.h" 67 #include "chrome/browser/ui/gtk/reload_button_gtk.h"
68 #include "chrome/browser/ui/gtk/status_bubble_gtk.h" 68 #include "chrome/browser/ui/gtk/status_bubble_gtk.h"
69 #include "chrome/browser/ui/gtk/tab_contents_container_gtk.h" 69 #include "chrome/browser/ui/gtk/tab_contents_container_gtk.h"
70 #include "chrome/browser/ui/gtk/tabs/tab_strip_gtk.h" 70 #include "chrome/browser/ui/gtk/tabs/tab_strip_gtk.h"
71 #include "chrome/browser/ui/gtk/task_manager_gtk.h" 71 #include "chrome/browser/ui/gtk/task_manager_gtk.h"
72 #include "chrome/browser/ui/gtk/update_recommended_dialog.h" 72 #include "chrome/browser/ui/gtk/update_recommended_dialog.h"
73 #include "chrome/browser/ui/gtk/website_settings_popup_gtk.h"
73 #include "chrome/browser/ui/omnibox/location_bar.h" 74 #include "chrome/browser/ui/omnibox/location_bar.h"
74 #include "chrome/browser/ui/omnibox/omnibox_view.h" 75 #include "chrome/browser/ui/omnibox/omnibox_view.h"
75 #include "chrome/browser/ui/page_info_bubble.h" 76 #include "chrome/browser/ui/page_info_bubble.h"
76 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" 77 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
77 #include "chrome/browser/ui/tabs/tab_strip_model.h" 78 #include "chrome/browser/ui/tabs/tab_strip_model.h"
78 #include "chrome/browser/ui/webui/task_manager/task_manager_dialog.h" 79 #include "chrome/browser/ui/webui/task_manager/task_manager_dialog.h"
79 #include "chrome/browser/web_applications/web_app.h" 80 #include "chrome/browser/web_applications/web_app.h"
80 #include "chrome/browser/website_settings.h"
81 #include "chrome/common/chrome_notification_types.h" 81 #include "chrome/common/chrome_notification_types.h"
82 #include "chrome/common/chrome_switches.h" 82 #include "chrome/common/chrome_switches.h"
83 #include "chrome/common/pref_names.h" 83 #include "chrome/common/pref_names.h"
84 #include "content/public/browser/download_manager.h" 84 #include "content/public/browser/download_manager.h"
85 #include "content/public/browser/native_web_keyboard_event.h" 85 #include "content/public/browser/native_web_keyboard_event.h"
86 #include "content/public/browser/notification_service.h" 86 #include "content/public/browser/notification_service.h"
87 #include "content/public/browser/render_view_host.h" 87 #include "content/public/browser/render_view_host.h"
88 #include "content/public/browser/render_widget_host_view.h" 88 #include "content/public/browser/render_widget_host_view.h"
89 #include "content/public/browser/web_contents.h" 89 #include "content/public/browser/web_contents.h"
90 #include "content/public/browser/web_contents_view.h" 90 #include "content/public/browser/web_contents_view.h"
(...skipping 1041 matching lines...) Expand 10 before | Expand all | Expand 10 after
1132 browser::ShowPageInfoBubble(window_, profile, url, ssl, show_history, 1132 browser::ShowPageInfoBubble(window_, profile, url, ssl, show_history,
1133 browser_.get()); 1133 browser_.get());
1134 } 1134 }
1135 1135
1136 void BrowserWindowGtk::ShowWebsiteSettings( 1136 void BrowserWindowGtk::ShowWebsiteSettings(
1137 Profile* profile, 1137 Profile* profile,
1138 TabContentsWrapper* tab_contents_wrapper, 1138 TabContentsWrapper* tab_contents_wrapper,
1139 const GURL& url, 1139 const GURL& url,
1140 const content::SSLStatus& ssl, 1140 const content::SSLStatus& ssl,
1141 bool show_history) { 1141 bool show_history) {
1142 WebsiteSettings::Show(GetNativeHandle(), 1142 WebsiteSettingsPopupGtk::Show(
1143 profile, 1143 GetNativeHandle(),
tfarina 2012/06/01 21:20:26 nit: like I said in the other comment, you could s
markusheintz_ 2012/06/02 21:22:33 I don't have any strong feelings about the style i
1144 tab_contents_wrapper, 1144 profile,
1145 url, 1145 tab_contents_wrapper,
1146 ssl); 1146 url,
1147 ssl);
1147 } 1148 }
1148 1149
1149 void BrowserWindowGtk::ShowAppMenu() { 1150 void BrowserWindowGtk::ShowAppMenu() {
1150 toolbar_->ShowAppMenu(); 1151 toolbar_->ShowAppMenu();
1151 } 1152 }
1152 1153
1153 bool BrowserWindowGtk::PreHandleKeyboardEvent( 1154 bool BrowserWindowGtk::PreHandleKeyboardEvent(
1154 const NativeWebKeyboardEvent& event, bool* is_keyboard_shortcut) { 1155 const NativeWebKeyboardEvent& event, bool* is_keyboard_shortcut) {
1155 GdkEventKey* os_event = &event.os_event->key; 1156 GdkEventKey* os_event = &event.os_event->key;
1156 1157
(...skipping 1442 matching lines...) Expand 10 before | Expand all | Expand 10 after
2599 wm_type == ui::WM_OPENBOX || 2600 wm_type == ui::WM_OPENBOX ||
2600 wm_type == ui::WM_XFWM4); 2601 wm_type == ui::WM_XFWM4);
2601 } 2602 }
2602 2603
2603 // static 2604 // static
2604 BrowserWindow* BrowserWindow::CreateBrowserWindow(Browser* browser) { 2605 BrowserWindow* BrowserWindow::CreateBrowserWindow(Browser* browser) {
2605 BrowserWindowGtk* browser_window_gtk = new BrowserWindowGtk(browser); 2606 BrowserWindowGtk* browser_window_gtk = new BrowserWindowGtk(browser);
2606 browser_window_gtk->Init(); 2607 browser_window_gtk->Init();
2607 return browser_window_gtk; 2608 return browser_window_gtk;
2608 } 2609 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/gtk/website_settings_popup_gtk.h » ('j') | chrome/browser/ui/gtk/website_settings_popup_gtk.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698