Remove any platform specific code from the chrome/browser/website_settings.* .

chrome/browser/ui/website_settings_ui.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_UI_H_
 #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_UI_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 14 matching lines @@
 namespace content {
 struct SSLStatus;
 }
 
 // The class |WebsiteSettingsUI| specifies the platform independent
 // interface of the website settings UI. The website settings UI displays
 // information and controls for site specific data (local stored objects like
 // cookies), site specific permissions (location, popup, plugin, etc.
 // permissions) and site specific information (identity, connection status,
 // etc.).
 class WebsiteSettingsUI {

[tfarina, 2012/05/31 19:23:01]

This is close to WebIntentPicker. You may have the "static void Show()" function
here. Just another suggestion to keep in mind, but to desconsider in your own.

  public:
   // |CookieInfo| contains information about the cookies from a specific source.
   // A source can for example be a specific origin or an entire domain.
   struct CookieInfo {
     CookieInfo();
 
     // String describing the cookie source.
     std::string cookie_source;
     // The number of allowed cookies.
     int allowed;
@@ skipping 30 matching lines @@
     int cert_id;
     // Status of the site's connection.
     WebsiteSettings::SiteConnectionStatus connection_status;
     // Textual description of the site's connection status that is displayed to
     // the user.
     std::string connection_status_description;
   };
 
   virtual ~WebsiteSettingsUI();
 
-  // Sets the |presenter| of the WebsiteSettingsUI that is responsible for
-  // setting the data to display in the UI.
-  virtual void SetPresenter(WebsiteSettings* presenter) = 0;
-
   // Sets cookie information.
   virtual void SetCookieInfo(const CookieInfoList& cookie_info_list) = 0;
 
   // Sets permision information.
   virtual void SetPermissionInfo(
       const PermissionInfoList& permission_info_list) = 0;
 
   // Sets site identity information.
   virtual void SetIdentityInfo(const IdentityInfo& identity_info) = 0;
 
   // Sets the first visited data. |first_visit| can be an empty string.
   virtual void SetFirstVisit(const string16& first_visit) = 0;
 };
 
 class CookieInfoList : public std::vector<WebsiteSettingsUI::CookieInfo> {

[tfarina, 2012/05/31 19:23:01]

unrelated: this is very uncommon. I think it's the same as:

typedef std::vector<..> CookieInfoList;

[markusheintz_, 2012/06/01 10:06:06]

I copied this from the cookie monster. This is the same way how the CookieList
is defined.

 

[tfarina, 2012/06/30 19:24:47]

I just found something about this in Item 7 of Effective STL from Scott Meyers.
And this is not good, because std::vector doesn't have a virtual destructor, so
inheriting from it is a no-no. We should fix this, both here and CookieList.

 };
 
 class PermissionInfoList
     : public std::vector<WebsiteSettingsUI::PermissionInfo> {
 };
 
 #endif  // CHROME_BROWSER_UI_WEBSITE_SETTINGS_UI_H_