Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: frog/tests/leg/ssa_phi_codegen_test.dart

Issue 10440087: Compute liveness of instructions to get better and fewer variable names. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | frog/tests/leg/type_guard_unuser_test.dart » ('j') | frog/tests/leg/type_inference_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/tests/leg/ssa_phi_codegen_test.dart
===================================================================
--- frog/tests/leg/ssa_phi_codegen_test.dart (revision 8089)
+++ frog/tests/leg/ssa_phi_codegen_test.dart (working copy)
@@ -66,15 +66,11 @@
Expect.isTrue(regexp.hasMatch(generated));
generated = compile(TEST_TWO, 'main');
- // TODO(ngeoffray): Add live range analysis to the codegen
- // to make this test pass.
regexp = new RegExp("t = \\(?$anyIdentifier +");
- Expect.isFalse(regexp.hasMatch(generated));
+ Expect.isTrue(regexp.hasMatch(generated));
- // TODO(ngeoffray): Add live range analysis to the codegen
- // to make this test pass.
regexp = new RegExp("i = \\(?$anyIdentifier +");
- Expect.isFalse(regexp.hasMatch(generated));
+ Expect.isTrue(regexp.hasMatch(generated));
generated = compile(TEST_THREE, 'foo');
« no previous file with comments | « no previous file | frog/tests/leg/type_guard_unuser_test.dart » ('j') | frog/tests/leg/type_inference_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698