frog/tests/leg/ssa_phi_codegen_test.dart - Issue 10440087: Compute liveness of instructions to get better and fewer variable names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: frog/tests/leg/ssa_phi_codegen_test.dart

Issue 10440087: Compute liveness of instructions to get better and fewer variable names. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: frog/tests/leg/ssa_phi_codegen_test.dart

===================================================================

--- frog/tests/leg/ssa_phi_codegen_test.dart (revision 8141)

+++ frog/tests/leg/ssa_phi_codegen_test.dart (working copy)

@@ -66,15 +66,11 @@

Expect.isTrue(regexp.hasMatch(generated));

generated = compile(TEST_TWO, 'main');

- // TODO(ngeoffray): Add live range analysis to the codegen

- // to make this test pass.

regexp = new RegExp("t = \\(?$anyIdentifier +");

- Expect.isFalse(regexp.hasMatch(generated));

+ Expect.isTrue(regexp.hasMatch(generated));

- // TODO(ngeoffray): Add live range analysis to the codegen

- // to make this test pass.

regexp = new RegExp("i = \\(?$anyIdentifier +");

- Expect.isFalse(regexp.hasMatch(generated));

+ Expect.isTrue(regexp.hasMatch(generated));

generated = compile(TEST_THREE, 'foo');

« no previous file with comments | « no previous file | frog/tests/leg/type_guard_unuser_test.dart » ('j') | no next file with comments »