chrome/browser/resources/gaia_auth/main.html - Issue 10440061: Remaining style fixes from http://codereview.chromium.org/10443024/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/gaia_auth/main.html

Issue 10440061: Remaining style fixes from http://codereview.chromium.org/10443024/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

	2 <head>

	3 <link rel="stylesheet" href="main.css">

	4 <meta charset="utf-8">

	5 </head>

2 <html>	6 <html>

3 <link rel="stylesheet" href="main.css">

4 <script src="util.js"></script>	7 <script src="util.js"></script>

5 <script src="main.js"></script>	8 <script src="main.js"></script>

6 <body><iframe id="gaia-frame" src="about:blank"	9 <body><iframe id="gaia-frame" src="about:blank"

7 frameborder="0"></iframe></body></html>	10 frameborder="0"></iframe></body>
	csilv 2012/05/25 23:39:19 nit: linefeed before </body> nit: linefeed before </body> zel 2012/05/25 23:46:43 Hmm, isn't that going to change my page design too Show quoted text On 2012/05/25 23:39:19, csilv wrote: > nit: linefeed before </body> Hmm, isn't that going to change my page design too? I can throw anything else than this frame on that page. csilv 2012/05/26 00:10:44 It won't change layout as long as it's just whites Show quoted text On 2012/05/25 23:46:43, zel wrote: > On 2012/05/25 23:39:19, csilv wrote: > > nit: linefeed before </body> > > Hmm, isn't that going to change my page design too? I can throw anything else > than this frame on that page. It won't change layout as long as it's just whitespace, iframe will get 100% height and width. Note my comment in css however about adding margin:0 to body.
	11 </html>

8	12

OLD	NEW