Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 10440053: Moved InstantiateTypeArgumentsComp and InstanceOfComp. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc (revision 8007)
+++ runtime/vm/flow_graph_builder.cc (working copy)
@@ -728,18 +728,21 @@
node->left()->Visit(&for_left_value);
Append(for_left_value);
Value* instantiator = NULL;
- Value* type_arguments = NULL;
- if (!type.IsInstantiated()) {
+ Value* instantiator_type_arguments = NULL;
+ if (type.IsInstantiated()) {
+ instantiator = BuildNullValue();
+ instantiator_type_arguments = BuildNullValue();
+ } else {
BuildTypecheckArguments(node->token_index(),
&instantiator,
- &type_arguments);
+ &instantiator_type_arguments);
}
InstanceOfComp* instance_of =
new InstanceOfComp(node->token_index(),
owner()->try_index(),
for_left_value.value(),
instantiator,
- type_arguments,
+ instantiator_type_arguments,
node->right()->AsTypeNode()->type(),
(node->kind() == Token::kISNOT));
ReturnComputation(instance_of);
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698