Correctly whitelist ftp directory listings.

Correctly whitelist ftp directory listings.

Instead of guessing whether a page is actually a directory listing that requires JavaScript to work, just store this information in the WebURLResponse

BUG=121399
TEST=manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138925

[jochen (gone - plz use gerrit), 2012-05-24 13:38:39]

Marja, please review

John, content/ approval
Tony, webkit/ approval

Adam, fyi

[marja, 2012-05-24 13:48:40]

lgtm modulo nits

https://chromiumcodereview.appspot.com/10440014/diff/1/chrome/renderer/conten...
File chrome/renderer/content_settings_observer.cc (right):

https://chromiumcodereview.appspot.com/10440014/diff/1/chrome/renderer/conten...
chrome/renderer/content_settings_observer.cc:316: // Whitelist ftp directory
listings, as they requier JavaScript to function
nit: require

https://chromiumcodereview.appspot.com/10440014/diff/1/content/renderer/rende...
File content/renderer/render_view_impl.cc (right):

https://chromiumcodereview.appspot.com/10440014/diff/1/content/renderer/rende...
content/renderer/render_view_impl.cc:1310: is_multipart_payload =
extra_data->is_multipart_payload();
nit: would "bool is_multipart_payload = extra_data &&
extra_data->is_multipart_payload();" be more compact / clear?

[jochen (gone - plz use gerrit), 2012-05-24 13:51:36]

all comments addressed

[jam, 2012-05-24 15:11:48]

http://codereview.chromium.org/10440014/diff/7001/webkit/glue/multipart_respo...
File webkit/glue/multipart_response_delegate.cc (left):

http://codereview.chromium.org/10440014/diff/7001/webkit/glue/multipart_respo...
webkit/glue/multipart_response_delegate.cc:271:
response.setIsMultipartPayload(has_sent_first_response_);
so can someone still do response.isMultipartPayload()? i.e. is there two getters
now for the same thing, or are you planning on getting rid of that?

[jochen (gone - plz use gerrit), 2012-05-24 15:21:40]

On 2012/05/24 15:11:48, John Abd-El-Malek wrote:
>
http://codereview.chromium.org/10440014/diff/7001/webkit/glue/multipart_respo...
> File webkit/glue/multipart_response_delegate.cc (left):
> 
>
http://codereview.chromium.org/10440014/diff/7001/webkit/glue/multipart_respo...
> webkit/glue/multipart_response_delegate.cc:271:
> response.setIsMultipartPayload(has_sent_first_response_);
> so can someone still do response.isMultipartPayload()? i.e. is there two
getters
> now for the same thing, or are you planning on getting rid of that?

I'll remove that from WebKit. As this field is not used by WebKit, it should be
handled entirely outside of it

[jochen (gone - plz use gerrit), 2012-05-24 15:29:25]

On 2012/05/24 15:21:40, jochen wrote:
> On 2012/05/24 15:11:48, John Abd-El-Malek wrote:
> >
>
http://codereview.chromium.org/10440014/diff/7001/webkit/glue/multipart_respo...
> > File webkit/glue/multipart_response_delegate.cc (left):
> > 
> >
>
http://codereview.chromium.org/10440014/diff/7001/webkit/glue/multipart_respo...
> > webkit/glue/multipart_response_delegate.cc:271:
> > response.setIsMultipartPayload(has_sent_first_response_);
> > so can someone still do response.isMultipartPayload()? i.e. is there two
> getters
> > now for the same thing, or are you planning on getting rid of that?
> 
> I'll remove that from WebKit. As this field is not used by WebKit, it should
be
> handled entirely outside of it

actually, disregard that. it is used by webcore for a check :-/

I'll remove the multipart bits from this CL

[tony, 2012-05-24 17:16:10]

lgtm

[commit-bot: I haz the power, 2012-05-24 20:52:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/10440014/9003

[commit-bot: I haz the power, 2012-05-24 23:06:11]

Change committed as 138925