Issue 10440013: Move chromeos::GetInterfacesFromIntrospectResult into IntrospectableClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10440013: Move chromeos::GetInterfacesFromIntrospectResult into IntrospectableClient (Closed)

Created:
8 years, 7 months ago by hashimoto

Modified:
8 years, 6 months ago

Reviewers:
keybuk, satorux1

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move chromeos::GetInterfacesFromIntrospectResult into IntrospectableClient Since XmlReader was moved from chrome/ to third_party/libxml/, now chromeos/ can depend on it. BUG=119583 TEST=chromeos_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139520

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -148 lines)			Patch
M	chrome/browser/chromeos/bluetooth/bluetooth_device.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
D	chrome/browser/chromeos/dbus/introspect_util.h	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	chrome/browser/chromeos/dbus/introspect_util.cc	View	1 chunk	+0 lines, -50 lines	0 comments	Download
D	chrome/browser/chromeos/dbus/introspect_util_unittest.cc	View	1 chunk	+0 lines, -68 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chromeos/DEPS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chromeos/chromeos.gyp	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chromeos/dbus/introspectable_client.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chromeos/dbus/introspectable_client.cc	View	3 chunks	+38 lines, -0 lines	0 comments	Download
A +	chromeos/dbus/introspectable_client_unittest.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10440013/1

8 years, 6 months ago (2012-05-30 07:51:23 UTC) #4

Change committed as 139520

Expand Messages | Collapse Messages