Hooking the discovery API to the NTP.

Hooking the discovery API to the NTP.

This replaces the previous discovery suggestion source with a version that gets its recommended links from extensions that implement the new experimental discovery API.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139685

[beaudoin, 2012-05-29 16:26:26]

@evan I reworked the suggestions discovery source so that it is no longer
linking to an hardcoded service but depends on links provided by the
experimental discovery extension instead.

@aaron Added a method to the suggestion registry to make that possible

@srinivas This will help you see which area of chromium the discovery stuff is
in. You should create a chromium account, this will make it easier to contribute
when you have to.

[Aaron Boodman, 2012-05-29 19:11:06]

LGTM

Philippe, please create api/discovery/OWNERS and add yourself to it so that you
don't need approval for these smaller changes. Please use your judgement on
whether a change is large enough to solicit feedback from the extensions team.

[Evan Stade, 2012-05-29 22:07:39]

http://codereview.chromium.org/10438004/diff/10001/chrome/browser/ui/webui/nt...
File chrome/browser/ui/webui/ntp/suggestions_source.h (right):

http://codereview.chromium.org/10438004/diff/10001/chrome/browser/ui/webui/nt...
chrome/browser/ui/webui/ntp/suggestions_source.h:9: #include "base/basictypes.h"
why did you add this here

http://codereview.chromium.org/10438004/diff/10001/chrome/browser/ui/webui/nt...
File chrome/browser/ui/webui/ntp/suggestions_source_discovery.h (right):

http://codereview.chromium.org/10438004/diff/10001/chrome/browser/ui/webui/nt...
chrome/browser/ui/webui/ntp/suggestions_source_discovery.h:12: #include
"base/basictypes.h"
why did you add this here?

http://codereview.chromium.org/10438004/diff/10001/chrome/browser/ui/webui/nt...
File chrome/browser/ui/webui/ntp/suggestions_source_top_sites.h (right):

http://codereview.chromium.org/10438004/diff/10001/chrome/browser/ui/webui/nt...
chrome/browser/ui/webui/ntp/suggestions_source_top_sites.h:11: #include
"base/basictypes.h"
why did you add this here?

[beaudoin, 2012-05-30 18:38:22]

http://codereview.chromium.org/10438004/diff/10001/chrome/browser/ui/webui/nt...
File chrome/browser/ui/webui/ntp/suggestions_source.h (right):

http://codereview.chromium.org/10438004/diff/10001/chrome/browser/ui/webui/nt...
chrome/browser/ui/webui/ntp/suggestions_source.h:9: #include "base/basictypes.h"
On 2012/05/29 22:07:39, Evan Stade wrote:
> why did you add this here

This is where DISALLOW_COPY_AND_ASSIGN() seems to be defined. I don't know why
it worked before, maybe because the .h was always included after some other?

http://codereview.chromium.org/10438004/diff/10001/chrome/browser/ui/webui/nt...
File chrome/browser/ui/webui/ntp/suggestions_source_discovery.h (right):

http://codereview.chromium.org/10438004/diff/10001/chrome/browser/ui/webui/nt...
chrome/browser/ui/webui/ntp/suggestions_source_discovery.h:12: #include
"base/basictypes.h"
On 2012/05/29 22:07:39, Evan Stade wrote:
> why did you add this here?

For DISALLOW_COPY_AND_ASSIGN.

http://codereview.chromium.org/10438004/diff/10001/chrome/browser/ui/webui/nt...
File chrome/browser/ui/webui/ntp/suggestions_source_top_sites.h (right):

http://codereview.chromium.org/10438004/diff/10001/chrome/browser/ui/webui/nt...
chrome/browser/ui/webui/ntp/suggestions_source_top_sites.h:11: #include
"base/basictypes.h"
On 2012/05/29 22:07:39, Evan Stade wrote:
> why did you add this here?

For DISALLOW_COPY_AND_ASSIGN.

[Evan Stade, 2012-05-30 21:10:36]

lgtm

[commit-bot: I haz the power, 2012-05-30 21:46:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/beaudoin@chromium.org/10438004/11023

[commit-bot: I haz the power, 2012-05-30 23:34:51]

Change committed as 139685