Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2155)

Unified Diff: chrome/browser/extensions/extension_tabs_module.cc

Issue 10436015: Remove chrome.windows.* support for platform apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_tabs_module_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_tabs_module.cc
diff --git a/chrome/browser/extensions/extension_tabs_module.cc b/chrome/browser/extensions/extension_tabs_module.cc
index 226a72a36f41887d842a3eac7381ba8f9c6e124e..529662790850d6efb7f9a96a9502eaea66c9c623 100644
--- a/chrome/browser/extensions/extension_tabs_module.cc
+++ b/chrome/browser/extensions/extension_tabs_module.cc
@@ -537,18 +537,6 @@ bool CreateWindowFunction::RunImpl() {
window_type = Browser::TYPE_PANEL;
else
window_type = Browser::TYPE_POPUP;
- } else if (type_str == keys::kWindowTypeValueShell &&
- GetExtension()->is_platform_app()) {
- // TODO(jeremya): remove this method of creating shell windows.
- GURL window_url = urls.empty() ? GURL(chrome::kAboutBlankURL) : urls[0];
- ShellWindow::CreateParams params;
- params.bounds = window_bounds;
- ShellWindow* shell_window = ShellWindow::Create(
- window_profile, GetExtension(), window_url, params);
- shell_window->Show();
- result_.reset(shell_window->extension_window_controller()->
- CreateWindowValueWithTabs());
- return true;
} else if (type_str != keys::kWindowTypeValueNormal) {
error_ = keys::kInvalidWindowTypeError;
return false;
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_tabs_module_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698