Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: jingle/notifier/listener/push_client_unittest.cc

Issue 10436013: [Sync] Make InvalidationNotifier use PushClient (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync to head Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « jingle/notifier/listener/push_client.cc ('k') | sync/notifier/cache_invalidation_packet_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: jingle/notifier/listener/push_client_unittest.cc
diff --git a/jingle/notifier/listener/push_client_unittest.cc b/jingle/notifier/listener/push_client_unittest.cc
index fd45466a0dc73bdd9850bea859c200a4bddcc793..42daf2a6d0456431c3b0f710f09bc7c75ae38969 100644
--- a/jingle/notifier/listener/push_client_unittest.cc
+++ b/jingle/notifier/listener/push_client_unittest.cc
@@ -33,13 +33,13 @@ class PushClientTest : public testing::Test {
};
// Make sure calling CreateDefault on the IO thread doesn't blow up.
-TEST_F(PushClientTest, OnIOThread) {
+TEST_F(PushClientTest, CreateDefaultOnIOThread) {
const scoped_ptr<PushClient> push_client(
PushClient::CreateDefault(notifier_options_));
}
// Make sure calling CreateDefault on a non-IO thread doesn't blow up.
-TEST_F(PushClientTest, OffIOThread) {
+TEST_F(PushClientTest, CreateDefaultOffIOThread) {
base::Thread thread("Non-IO thread");
EXPECT_TRUE(thread.Start());
thread.message_loop()->PostTask(
@@ -49,6 +49,13 @@ TEST_F(PushClientTest, OffIOThread) {
thread.Stop();
}
+// Make sure calling CreateDefaultOnIOThread on the IO thread doesn't
+// blow up.
+TEST_F(PushClientTest, CreateDefaultOnIOThreadOnIOThread) {
+ const scoped_ptr<PushClient> push_client(
+ PushClient::CreateDefaultOnIOThread(notifier_options_));
+}
+
} // namespace
} // namespace notifier
« no previous file with comments | « jingle/notifier/listener/push_client.cc ('k') | sync/notifier/cache_invalidation_packet_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698