Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: content/browser/web_contents/interstitial_page_impl.cc

Issue 10436010: Multi-select <select> in 'external popup window' (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/interstitial_page_impl.cc
diff --git a/content/browser/web_contents/interstitial_page_impl.cc b/content/browser/web_contents/interstitial_page_impl.cc
index e9cdf85c4a8a7b199a48c3302d9456fe2c9eaf1e..a8d80ed78688328790a4eb99e911f38cd987e236 100644
--- a/content/browser/web_contents/interstitial_page_impl.cc
+++ b/content/browser/web_contents/interstitial_page_impl.cc
@@ -86,13 +86,20 @@ class InterstitialPageImpl::InterstitialPageRVHDelegateView
explicit InterstitialPageRVHDelegateView(InterstitialPageImpl* page);
// RenderViewHostDelegateView implementation:
+ virtual void ShowPopupMenu(const gfx::Rect& bounds,
+ int item_height,
+ double item_font_size,
+ int selected_item,
+ const std::vector<WebMenuItem>& items,
+ bool right_aligned,
+ bool allow_multiple_selection) OVERRIDE;
virtual void StartDragging(const WebDropData& drop_data,
WebDragOperationsMask operations_allowed,
const SkBitmap& image,
- const gfx::Point& image_offset);
- virtual void UpdateDragCursor(WebDragOperation operation);
- virtual void GotFocus();
- virtual void TakeFocus(bool reverse);
+ const gfx::Point& image_offset) OVERRIDE;
+ virtual void UpdateDragCursor(WebDragOperation operation) OVERRIDE;
+ virtual void GotFocus() OVERRIDE;
+ virtual void TakeFocus(bool reverse) OVERRIDE;
virtual void OnFindReply(int request_id,
int number_of_matches,
const gfx::Rect& selection_rect,
@@ -693,6 +700,17 @@ InterstitialPageImpl::InterstitialPageRVHDelegateView::
: interstitial_page_(page) {
}
+void InterstitialPageImpl::InterstitialPageRVHDelegateView::ShowPopupMenu(
+ const gfx::Rect& bounds,
+ int item_height,
+ double item_font_size,
+ int selected_item,
+ const std::vector<WebMenuItem>& items,
+ bool right_aligned,
+ bool allow_multiple_selection) {
+ NOTREACHED() << "InterstitialPage does not support showing popup menus.";
+}
+
void InterstitialPageImpl::InterstitialPageRVHDelegateView::StartDragging(
const WebDropData& drop_data,
WebDragOperationsMask allowed_operations,
« no previous file with comments | « content/browser/renderer_host/render_view_host_unittest.cc ('k') | content/browser/web_contents/web_contents_view_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698