Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: content/browser/web_contents/web_contents_view_gtk.cc

Issue 10436010: Multi-select <select> in 'external popup window' (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase after reverts and re-reverts.. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_view_gtk.cc
diff --git a/content/browser/web_contents/web_contents_view_gtk.cc b/content/browser/web_contents/web_contents_view_gtk.cc
index d118130ca2764e517abaf7c1436ac4dd7411aaf5..fb237f3dd3e681ca92ccb50310160bd09ddbdbe8 100644
--- a/content/browser/web_contents/web_contents_view_gtk.cc
+++ b/content/browser/web_contents/web_contents_view_gtk.cc
@@ -332,6 +332,18 @@ void WebContentsViewGtk::ShowContextMenu(
DLOG(ERROR) << "Cannot show context menus without a delegate.";
}
+void WebContentsViewGtk::ShowPopupMenu(const gfx::Rect& bounds,
+ int item_height,
+ double item_font_size,
+ int selected_item,
+ const std::vector<WebMenuItem>& items,
+ bool right_aligned,
+ bool allow_multiple_selection) {
+ // We are not using external popup menus on Linux, they are rendered by
+ // WebKit.
+ NOTREACHED();
Avi (use Gerrit) 2012/05/24 18:41:41 Standardize the implementations of ShowPopupMenu a
aruslan 2012/05/24 19:53:15 Done.
+}
+
// Render view DnD -------------------------------------------------------------
void WebContentsViewGtk::StartDragging(const WebDropData& drop_data,

Powered by Google App Engine
This is Rietveld 408576698