Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: content/browser/renderer_host/popup_menu_helper_mac.mm

Issue 10436010: Multi-select <select> in 'external popup window' (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase after reverts and re-reverts.. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/popup_menu_helper_mac.mm
diff --git a/content/browser/renderer_host/popup_menu_helper_mac.mm b/content/browser/renderer_host/popup_menu_helper_mac.mm
index 9f371486693f8d20bbc04c008cccf67c0c0a84b8..5befbe10539aed6aa312c7514ba5b6a4482e85cf 100644
--- a/content/browser/renderer_host/popup_menu_helper_mac.mm
+++ b/content/browser/renderer_host/popup_menu_helper_mac.mm
@@ -33,7 +33,11 @@ void PopupMenuHelper::ShowPopupMenu(
double item_font_size,
int selected_item,
const std::vector<WebMenuItem>& items,
- bool right_aligned) {
+ bool right_aligned,
+ bool allow_multiple_selection) {
+ // Only single selection list boxes show a popup on Mac.
+ DCHECK(!allow_multiple_selection);
+
// Retain the Cocoa view for the duration of the pop-up so that it can't be
// dealloced if my Destroy() method is called while the pop-up's up (which
// would in turn delete me, causing a crash once the -runMenuInView

Powered by Google App Engine
This is Rietveld 408576698