Issue 10436002: Remove use of BrowserList::GetLastActive from PrintDialogGtk. Pass through the parent GtkWidget ins…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10436002: Remove use of BrowserList::GetLastActive from PrintDialogGtk. Pass through the parent GtkWidget ins… (Closed)

Created:
8 years, 7 months ago by Ben Goodger (Google)

Modified:
8 years, 7 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove use of BrowserList::GetLastActive from PrintDialogGtk. Pass through the parent GtkWidget instead and locate a parent window from that. http://crbug.com/129187 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138714

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
M	chrome/browser/printing/print_dialog_gtk.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/printing/print_dialog_gtk.cc	View	1 2	2 chunks	+2 lines, -4 lines	0 comments	Download
M	printing/print_dialog_gtk_interface.h	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	printing/printing_context_gtk.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/10436002/6001

8 years, 7 months ago (2012-05-23 23:03:36 UTC) #3

commit-bot: I haz the power

8 years, 7 months ago (2012-05-23 23:03:45 UTC) #4

Presubmit check for 10436002-6001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/printing
    printing

Presubmit checks took 1.9s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

Expand Messages | Collapse Messages