Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10435007: [Sync] Fix sync_listen_notifications to use a real host resolver (Closed)

Created:
8 years, 7 months ago by akalin
Modified:
8 years, 7 months ago
Reviewers:
szym
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

[Sync] Fix sync_listen_notifications to use a real host resolver r138413 switched TestURLRequestContext to use a mock HostResolver by default. Clean up sync DEPS a bit. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138947

Patch Set 1 #

Patch Set 2 : Fix DEPS #

Total comments: 2

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -4 lines) Patch
M sync/DEPS View 1 1 chunk +0 lines, -3 lines 0 comments Download
M sync/tools/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M sync/tools/sync_listen_notifications.cc View 1 2 3 chunks +37 lines, -1 line 0 comments Download
M sync/util/DEPS View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
akalin
+szym for review
8 years, 7 months ago (2012-05-23 23:57:51 UTC) #1
szym
lgtm https://chromiumcodereview.appspot.com/10435007/diff/5001/sync/tools/sync_listen_notifications.cc File sync/tools/sync_listen_notifications.cc (right): https://chromiumcodereview.appspot.com/10435007/diff/5001/sync/tools/sync_listen_notifications.cc#newcode157 sync/tools/sync_listen_notifications.cc:157: } nit: no need for braces
8 years, 7 months ago (2012-05-24 04:33:44 UTC) #2
akalin
Addressed comments, committing via trybot http://codereview.chromium.org/10435007/diff/5001/sync/tools/sync_listen_notifications.cc File sync/tools/sync_listen_notifications.cc (right): http://codereview.chromium.org/10435007/diff/5001/sync/tools/sync_listen_notifications.cc#newcode157 sync/tools/sync_listen_notifications.cc:157: } On 2012/05/24 04:33:44, ...
8 years, 7 months ago (2012-05-24 23:19:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/10435007/10001
8 years, 7 months ago (2012-05-24 23:20:41 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-25 00:34:31 UTC) #5 
Change committed as 138947

Powered by Google App Engine
This is Rietveld 408576698