No longer trigger SyncCredentialsLost flow on cros.

No longer trigger SyncCredentialsLost flow on cros.

On auto_start platforms (cros/android) we no longer start the sync backend until we have a chromiumsync token available.

BUG=128592
TEST=Log in on cros, see sync start up.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138735

[Andrew T Wilson (Slow), 2012-05-23 22:38:09]

PTAL - this no longer lets sync use bogus creds on cros.

[Nicolas Zea, 2012-05-23 22:54:11]

LGTM with a small test change.

I'm still nervous that the real reason for the auth issues is the proxy (in
which case it may be that desktop builds with a proxy might hit it?), but even
so this fix is still probably correct.

http://codereview.chromium.org/10434009/diff/1/chrome/browser/sync/profile_sy...
File chrome/browser/sync/profile_sync_service_startup_unittest.cc (right):

http://codereview.chromium.org/10434009/diff/1/chrome/browser/sync/profile_sy...
chrome/browser/sync/profile_sync_service_startup_unittest.cc:180:
service_->Initialize();
maybe add EXPECT_FALSE(GetBackendForTest()) to ensure InitializeBackend isn't
called?

http://codereview.chromium.org/10434009/diff/1/chrome/browser/sync/profile_sy...
chrome/browser/sync/profile_sync_service_startup_unittest.cc:215:
service_->Initialize();
after this too

http://codereview.chromium.org/10434009/diff/1/chrome/browser/sync/profile_sy...
chrome/browser/sync/profile_sync_service_startup_unittest.cc:225:
EXPECT_FALSE(service_->ShouldPushChanges());
and here

[Andrew T Wilson (Slow), 2012-05-23 23:44:52]

Yeah, I suspect there's still other issues going on with fetching OAuth tokens
on cros. But our behavior here is definitely wrong and is exacerbating the
issue.

https://chromiumcodereview.appspot.com/10434009/diff/1/chrome/browser/sync/pr...
File chrome/browser/sync/profile_sync_service_startup_unittest.cc (right):

https://chromiumcodereview.appspot.com/10434009/diff/1/chrome/browser/sync/pr...
chrome/browser/sync/profile_sync_service_startup_unittest.cc:180:
service_->Initialize();
On 2012/05/23 22:54:11, nzea wrote:
> maybe add EXPECT_FALSE(GetBackendForTest()) to ensure InitializeBackend isn't
> called?

Done.

https://chromiumcodereview.appspot.com/10434009/diff/1/chrome/browser/sync/pr...
chrome/browser/sync/profile_sync_service_startup_unittest.cc:215:
service_->Initialize();
On 2012/05/23 22:54:11, nzea wrote:
> after this too

Done.

https://chromiumcodereview.appspot.com/10434009/diff/1/chrome/browser/sync/pr...
chrome/browser/sync/profile_sync_service_startup_unittest.cc:225:
EXPECT_FALSE(service_->ShouldPushChanges());
On 2012/05/23 22:54:11, nzea wrote:
> and here

Done.

[commit-bot: I haz the power, 2012-05-23 23:45:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/atwilson@chromium.org/10434009/7001