Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: vm/object.h

Issue 10433003: Make Dart_GetClass work for private classes. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/dart_api_impl_test.cc ('k') | vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/object.h
===================================================================
--- vm/object.h (revision 7924)
+++ vm/object.h (working copy)
@@ -1733,10 +1733,15 @@
static RawLibrary* New(const String& url);
// Library scope name dictionary.
+ //
+ // TODO(turnidge): The Lookup functions are not consistent in how
+ // they deal with private names. Go through and make them a bit
+ // more regular.
void AddClass(const Class& cls) const;
void AddObject(const Object& obj, const String& name) const;
RawObject* LookupObject(const String& name) const;
RawClass* LookupClass(const String& name) const;
+ RawClass* LookupClassAllowPrivate(const String& name) const;
RawObject* LookupLocalObject(const String& name) const;
RawClass* LookupLocalClass(const String& name) const;
RawField* LookupFieldAllowPrivate(const String& name) const;
« no previous file with comments | « vm/dart_api_impl_test.cc ('k') | vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698