First step toward an optimizing compiler:

runtime/vm/intermediate_language_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/flow_graph_compiler.h"
 #include "vm/locations.h"
+#include "vm/object_store.h"
 #include "vm/stub_code.h"
 
 #define __ compiler->assembler()->
 
 namespace dart {
 
 
 // True iff. the arguments to a call will be properly pushed and can
 // be popped after the call.
 template <typename T> static bool VerifyCallComputation(T* comp) {
@@ skipping 116 matching lines @@
 }
 
 
 LocationSummary* InstanceCallComp::MakeLocationSummary() const {
   return MakeCallSummary();
 }
 
 
 void InstanceCallComp::EmitNativeCode(FlowGraphCompiler* compiler) {
   ASSERT(VerifyCallComputation(this));
+  compiler->AddCurrentDescriptor(PcDescriptors::kDeopt,
+                                 cid(),
+                                 token_index(),
+                                 try_index());
   compiler->EmitInstanceCall(cid(),
                              token_index(),
                              try_index(),
                              function_name(),
                              ArgumentCount(),
                              argument_names(),
                              checked_argument_count());
 }
 
 
@@ skipping 354 matching lines @@
 LocationSummary* CatchEntryComp::MakeLocationSummary() const {
   return NULL;
 }
 
 
 void CatchEntryComp::EmitNativeCode(FlowGraphCompiler* compiler) {
   UNIMPLEMENTED();
 }
 
 
+LocationSummary* BinaryOpComp::MakeLocationSummary() const {
+  return MakeSimpleLocationSummary(2, Location::SameAsFirstInput());
+}
+
+
+// TODO(srdjan): Implement variations.
+static bool TryEmitSmiBinaryOp(FlowGraphCompiler* compiler,
+                               BinaryOpComp* comp) {
+  ASSERT((comp->ic_data() != NULL));
+  const ICData& ic_data = *comp->ic_data();
+  if (ic_data.IsNull()) return false;
+  if (ic_data.num_args_tested() != 2) return false;
+  if (ic_data.NumberOfChecks() != 1) return false;
+  Function& target = Function::Handle();
+  GrowableArray<const Class*> classes;
+  ic_data.GetCheckAt(0, &classes, &target);
+  const Class& smi_class =
+      Class::Handle(Isolate::Current()->object_store()->smi_class());
+  if ((classes[0]->raw() != smi_class.raw()) ||
+      (classes[1]->raw() != smi_class.raw())) {
+    return false;
+  }
+  // TODO(srdjan): need to allocate a temporary register (now using r10)
+  Register left = comp->locs()->in(0).reg();
+  Register right = comp->locs()->in(1).reg();
+  Register result = comp->locs()->out().reg();
+  Register temp = R10;
+  Label* deopt = compiler->AddDeoptStub(comp->instance_call()->cid(),
+                                        comp->instance_call()->token_index(),
+                                        comp->instance_call()->try_index(),
+                                        kDeoptSmiBinaryOp,
+                                        temp,
+                                        right);
+  __ movq(temp, left);
+  __ orq(left, right);
+  __ testq(left, Immediate(kSmiTagMask));
+  __ j(NOT_ZERO, deopt);
+  __ movq(left, temp);
+  switch (comp->op_kind()) {
+    case Token::kADD: {
+      __ addq(left, right);
+      __ j(OVERFLOW, deopt);
+      if (result != left) {
+        __ movq(result, left);
+      }
+      break;
+    }
+    default:
+      UNREACHABLE();
+  }
+  return true;
+}
+
+void BinaryOpComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  if (TryEmitSmiBinaryOp(compiler, this)) {
+    // Operation inlined.
+    return;
+  }
+  Register left = locs()->in(0).reg();
+  Register right = locs()->in(1).reg();
+  __ pushq(left);
+  __ pushq(right);

[Florian Schneider, 2012/05/24 02:13:30]

It would be nice to avoid having to push the arguments back before emitting the
instance call code if inlining does not work out.

Would it be possible to determine already in the FlowGraphOptimizer whether to
inline or not, so that we don't have to deal with the non-inlined case here?

[srdjan, 2012/05/24 16:41:19]

This code is only transition code (adding comment).
 Yes, the optimizer should convert to binop only if the inlining is possible.

  // TODO(srdjan): Remove this code once BinaryOpComp has been implemeneted
  // for all intended operations.

+  InstanceCallComp* instance_call_comp = instance_call();
+  instance_call_comp->EmitNativeCode(compiler);
+  if (locs()->out().reg() != RAX) {
+    __ movq(locs()->out().reg(), RAX);
+  }
+}
+
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64