Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 10427008: Merge 118039 - Source/WebCore: Fix iframe printing. (Closed)

Created:
8 years, 7 months ago by jsbell
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Visibility:
Public.

Description

Merge 118039 - Source/WebCore: Fix iframe printing. https://bugs.webkit.org/show_bug.cgi?id=85118 Patch by Vitaly Buka <vitalybuka@chromium.org>; on 2012-05-22 Reviewed by Darin Adler, Eric Seidel. Patch fixed two issues by disabling special handling of subframes for printing. 1. Regression. Division by zero when forceLayoutForPagination called for subframes and page sizes set to zero. 2. Old issue. RendererView adjusted layout of subframes for printing and set invalid dimensions. Sometimes it caused missing iframe when printed. Test: printing/iframe-print.html * page/Frame.cpp: (WebCore::Frame::setPrinting): Calls forceLayoutForPagination for root frames only. (WebCore::Frame::resizePageRectsKeepingRatio): Added ASSERTs to catch division by zero. * rendering/RenderView.cpp: Replaced printing() with shouldUsePrintingLayout() for most calls. (WebCore::RenderView::computeLogicalHeight): (WebCore::RenderView::computeLogicalWidth): (WebCore::RenderView::layout): (WebCore::RenderView::shouldUsePrintingLayout): Returns true only if printing enabled and it's a root frame. (WebCore::RenderView::viewRect): (WebCore::RenderView::viewHeight): (WebCore::RenderView::viewWidth): * rendering/RenderView.h: TBR=commit-queue@webkit.org,vitalybuka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118243

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M Source/WebCore/page/Frame.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
M Source/WebCore/rendering/RenderView.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderView.cpp View 6 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jsbell
8 years, 7 months ago (2012-05-23 21:11:42 UTC) #1
Vitaly Buka (NO REVIEWS)
8 years, 7 months ago (2012-05-23 21:12:03 UTC) #2
On 2012/05/23 21:11:42, jsbell wrote:

ltgm

Powered by Google App Engine
This is Rietveld 408576698