Issue 10426010: Use HAVE_POSIX_MEMALIGN instead of HAS_POSIX_MEMALIGN

Issue 10426010: Use HAVE_POSIX_MEMALIGN instead of HAS_POSIX_MEMALIGN (Closed)

Created:
8 years, 7 months ago by tpayne

Modified:
8 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, Noel Gordon

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Use HAVE_POSIX_MEMALIGN instead of HAS_POSIX_MEMALIGN BUG=129462 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138718

Patch Set 2 : Addressed feedback #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
M	third_party/qcms/README.chromium	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	third_party/qcms/google.patch	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	third_party/qcms/src/transform.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

I don't really understand what this patch is intending to do, as the bug report ...

8 years, 7 months ago (2012-05-23 22:40:35 UTC) #2

tpayne

Did you take a look at the mozilla bug? Basically, it's checking a #define that ...

8 years, 7 months ago (2012-05-23 22:51:12 UTC) #3

Evan Stade

d'oh! I don't know how I missed that. lgtm https://chromiumcodereview.appspot.com/10426010/diff/1/third_party/qcms/README.chromium File third_party/qcms/README.chromium (right): https://chromiumcodereview.appspot.com/10426010/diff/1/third_party/qcms/README.chromium#newcode20 third_party/qcms/README.chromium:20: ...

8 years, 7 months ago (2012-05-23 22:53:43 UTC) #4

tpayne

On 2012/05/23 22:53:43, Evan Stade wrote: > d'oh! I don't know how I missed that. ...

8 years, 7 months ago (2012-05-23 22:58:25 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tpayne@chromium.org/10426010/5

8 years, 7 months ago (2012-05-23 22:58:53 UTC) #6

Change committed as 138718

Expand Messages | Collapse Messages