Run PNGs in ui/resources through PNGCrush.

Run PNGs in ui/resources through PNGCrush.

BUG=none
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138628

[Lei Zhang, 2012-05-23 22:15:50]

4017536 -> 3987723 bytes.

[oshima, 2012-05-23 22:25:39]

LGTM

thanks, msw told me about this earlier this week and I wanted to learn how to do
this as new assets are on the way.

Is there a chrome way to do this, or I can just grab pngcrush and run them
through it?

[Lei Zhang, 2012-05-23 22:27:06]

On 2012/05/23 22:25:39, oshima wrote:
> LGTM
> 
> thanks, msw told me about this earlier this week and I wanted to learn how to
do
> this as new assets are on the way.
> 
> Is there a chrome way to do this, or I can just grab pngcrush and run them
> through it?

I just ran:

cd ui/resources
for `f in find . -name '*.png'`; do
pngcrush $f /tmp/foo.png && mv /tmp/foo.png $f
done

[oshima, 2012-05-23 22:30:56]

On 2012/05/23 22:27:06, Lei Zhang wrote:
> On 2012/05/23 22:25:39, oshima wrote:
> > LGTM
> > 
> > thanks, msw told me about this earlier this week and I wanted to learn how
to
> do
> > this as new assets are on the way.
> > 
> > Is there a chrome way to do this, or I can just grab pngcrush and run them
> > through it?
> 
> I just ran:
> 
> cd ui/resources
> for `f in find . -name '*.png'`; do
> pngcrush $f /tmp/foo.png && mv /tmp/foo.png $f
> done

got it.

[msw, 2012-05-23 22:47:26]

PNGCrush alone isn't ideal. You'll also want to strip iTXt, tEXt, zTXt, and tIME
chunks *and run PNGSlim* for non-trivial additional lossless size reduction.
I've been meaning to write up these instructions for a while, but you can get
the gist from:

crbug.com/76282 and codereview.chromium.org/7782022 and cmd:
pngcrush.exe -reduce -brute -rem iTXt -rem tEXt -rem zTXt -rem tIME

[oshima, 2012-05-23 22:55:44]

We probably should have a command that anyone can run, or make it a part of
grd processing.

- oshima

On Wed, May 23, 2012 at 3:47 PM, <msw@chromium.org> wrote:

> PNGCrush alone isn't ideal. You'll also want to strip iTXt, tEXt, zTXt,
> and tIME
> chunks *and run PNGSlim* for non-trivial additional lossless size
> reduction.
> I've been meaning to write up these instructions for a while, but you can
> get
> the gist from:
>
> crbug.com/76282 and
codereview.chromium.org/**7782022<http://codereview.chromium.org/7782022>and
cmd:
> pngcrush.exe -reduce -brute -rem iTXt -rem tEXt -rem zTXt -rem tIME
>
>
https://chromiumcodereview.**appspot.com/10426009/<https://chromiumcodereview...
>

[msw, 2012-05-23 22:59:23]

> We probably should have a command that anyone can run, or make it a part of
grd processing.
Agreed, but the last time we discussed doing that, it was deemed too costly to
run with each build, and perhaps blocked on porting the currently
Windows-specific PNGSlim bat file and constituent functionality; gah, I should
probably file bugs on all this...