Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: vm/flow_graph_compiler_x64.cc

Issue 10425007: Move two more instructions to intermediate_language_x64.cc. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/flow_graph_compiler_x64.cc
===================================================================
--- vm/flow_graph_compiler_x64.cc (revision 7916)
+++ vm/flow_graph_compiler_x64.cc (working copy)
@@ -1037,35 +1037,15 @@
void FlowGraphCompiler::VisitAllocateObject(AllocateObjectComp* comp) {
- const Class& cls = Class::ZoneHandle(comp->constructor().owner());
- const Code& stub = Code::Handle(StubCode::GetAllocationStubForClass(cls));
- const ExternalLabel label(cls.ToCString(), stub.EntryPoint());
- GenerateCall(comp->token_index(), comp->try_index(), &label,
- PcDescriptors::kOther);
- __ Drop(comp->arguments().length()); // Discard allocation argument.
+ // Moved to intermediate_language_x64.cc.
+ UNREACHABLE();
}
void FlowGraphCompiler::VisitAllocateObjectWithBoundsCheck(
AllocateObjectWithBoundsCheckComp* comp) {
- const Class& cls = Class::ZoneHandle(comp->constructor().owner());
- __ popq(RCX); // Pop instantiator type arguments.
- __ popq(RAX); // Pop type arguments.
-
- // Push the result place holder initialized to NULL.
- __ PushObject(Object::ZoneHandle());
- __ pushq(Immediate(Smi::RawValue(comp->token_index())));
- __ PushObject(cls);
- __ pushq(RAX); // Push type arguments.
- __ pushq(RCX); // Push instantiator type arguments.
- GenerateCallRuntime(comp->cid(),
- comp->token_index(),
- comp->try_index(),
- kAllocateObjectWithBoundsCheckRuntimeEntry);
- // Pop instantiator type arguments, type arguments, class, and
- // source location.
- __ Drop(4);
- __ popq(RAX); // Pop new instance.
+ // Moved to intermediate_language_x64.cc.
+ UNREACHABLE();
}
« no previous file with comments | « no previous file | vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698