Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java

Issue 10425002: Resolve operators to int/double instead of num where possible (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Test for ~/ with doubles Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
diff --git a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
index e085cf2bd0b5148bd8678166b37486b144623fdc..aa1387d58e01bcee3ea6a9c3ca8bffe61414de01 100644
--- a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
+++ b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
@@ -1150,7 +1150,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
expectedList.add("bool");
expectedList.add("bool");
expectedList.add("int");
- expectedList.add("num");
+ expectedList.add("int");
expectedList.add("double");
expectedList.add("double");
expectedList.add("Map<String, int>");
@@ -1302,6 +1302,45 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
assertVariableTypeString(libraryResult, "v1", "String");
}
+ public void test_binaryExpressionType() throws Exception {
+ AnalyzeLibraryResult libraryResult = analyzeLibrary(
+ "f() {",
+ " var v1 = 1 + 2;",
+ " var v2 = 1 - 2;",
+ " var v3 = 1 * 2;",
+ " var v4 = 1 ~/ 2;",
+ " var v5 = 1 % 2;",
+ " var v6 = 1 / 2;",
+ " var v7 = 1.0 + 2;",
+ " var v8 = 1 + 2.0;",
+ " var v9 = 1 - 2.0;",
+ " var v10 = 1.0 - 2;",
+ " var v11 = 1 * 2.0;",
+ " var v12 = 1.0 * 2;",
+ " var v13 = 1.0 / 2;",
+ " var v14 = 1 / 2.0;",
+ " var v15 = 1.0 ~/ 2.0;",
+ " var v16 = 1.0 ~/ 2;",
+ "}",
+ "");
+ assertVariableTypeString(libraryResult, "v1", "int");
+ assertVariableTypeString(libraryResult, "v2", "int");
+ assertVariableTypeString(libraryResult, "v3", "int");
+ assertVariableTypeString(libraryResult, "v4", "int");
+ assertVariableTypeString(libraryResult, "v5", "int");
+ assertVariableTypeString(libraryResult, "v6", "double");
+ assertVariableTypeString(libraryResult, "v7", "double");
+ assertVariableTypeString(libraryResult, "v8", "double");
+ assertVariableTypeString(libraryResult, "v9", "double");
+ assertVariableTypeString(libraryResult, "v10", "double");
+ assertVariableTypeString(libraryResult, "v11", "double");
+ assertVariableTypeString(libraryResult, "v12", "double");
+ assertVariableTypeString(libraryResult, "v13", "double");
+ assertVariableTypeString(libraryResult, "v14", "double");
+ assertVariableTypeString(libraryResult, "v15", "double");
+ assertVariableTypeString(libraryResult, "v16", "double");
+ }
+
/**
* Asserts that {@link VariableElement} with given name has expected type.
*/

Powered by Google App Engine
This is Rietveld 408576698