Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 10424007: [OSX/Pepper] Don't have browser cache shmem ref behind ImageData. (Closed)

Created:
8 years, 7 months ago by Scott Hess - ex-Googler
Modified:
8 years, 6 months ago
Reviewers:
brettw, viettrungluu
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[OSX/Pepper] Don't have browser cache shmem ref behind ImageData. On OSX the browser has to create shmem blocks for sandboxed processes. The browser process can keep a handle for synchronizing between processes by id, but pepper's implementation just passes the handle between processes so that is not necessary. Before, the browser ran out of handles which breaks all sorts of stuff, but everything kept running, with various visual glitches (and no fds in browser is really bad). With this change, the renderer crashes. That sounds bad, but is actually better in terms of resolving the underlying problems. Also, histogram sizes for all platforms. Using a TransportDIB for small images is probably a bad idea. The histograms should show how things are being used in the wild. BUG=129430 TEST=flapper works, histograms appear. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139366

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M content/renderer/pepper/pepper_platform_image_2d_impl.cc View 3 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Scott Hess - ex-Googler
vtl for thumbs-up, brettw for final owner stamp.
8 years, 7 months ago (2012-05-23 20:12:38 UTC) #1
Scott Hess - ex-Googler
ping?
8 years, 7 months ago (2012-05-25 19:29:03 UTC) #2
brettw
lgtm
8 years, 7 months ago (2012-05-25 21:51:41 UTC) #3
viettrungluu
LGTM if everything still works (or, better yet, works better).
8 years, 7 months ago (2012-05-26 02:34:56 UTC) #4
viettrungluu
On 2012/05/26 02:34:56, viettrungluu wrote: > LGTM if everything still works (or, better yet, works ...
8 years, 7 months ago (2012-05-26 02:36:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10424007/1
8 years, 6 months ago (2012-05-29 17:17:11 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-05-29 20:41:10 UTC) #7
Change committed as 139366

Powered by Google App Engine
This is Rietveld 408576698