Adding unit tests for PrerenderDispatcher.

chrome/renderer/prerender/prerender_dispatcher_unittest.cc

Index: chrome/renderer/prerender/prerender_dispatcher_unittest.cc
diff --git a/chrome/renderer/prerender/prerender_dispatcher_unittest.cc b/chrome/renderer/prerender/prerender_dispatcher_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d3dd28e573dac39104d6e7f76c29c72a43ea8627
--- /dev/null
+++ b/chrome/renderer/prerender/prerender_dispatcher_unittest.cc
@@ -0,0 +1,111 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/renderer/prerender/prerender_dispatcher.h"
+
+#include "base/compiler_specific.h"
+#include "base/logging.h"
+#include "googleurl/src/gurl.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace prerender {
+
+class PrerenderDispatcherTest : public testing::Test {
+ public:
+  PrerenderDispatcherTest() {}

[gavinp, 2012/05/24 15:58:56]

const PrerenderDispatcher::PrerenderMap& prerender_urls() { return
prerender_dispatcher_.prerender_urls_; }

and use it to shorten all of the prerender_dispatcher_.prerender_urls_ below, as
well as getting const testing on access?

+
+  PrerenderDispatcher prerender_dispatcher_;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(PrerenderDispatcherTest);
+};
+
+TEST_F(PrerenderDispatcherTest, PrerenderDispatcherEmpty) {
+  EXPECT_EQ(0U, prerender_dispatcher_.prerender_urls_.size());
+}
+
+TEST_F(PrerenderDispatcherTest, PrerenderDispatcherSingleAdd) {
+  GURL foo_url = GURL("http://foo.com");
+  EXPECT_FALSE(prerender_dispatcher_.IsPrerenderURL(foo_url));
+  prerender_dispatcher_.OnAddPrerenderURL(foo_url);
+  EXPECT_TRUE(prerender_dispatcher_.IsPrerenderURL(foo_url));
+
+  PrerenderDispatcher::PrerenderMap::const_iterator entry =
+      prerender_dispatcher_.prerender_urls_.find(foo_url);
+  EXPECT_FALSE(prerender_dispatcher_.prerender_urls_.end() == entry);
+  EXPECT_EQ(1, entry->second);
+}
+
+TEST_F(PrerenderDispatcherTest, PrerenderDispatcherMultipleAdd) {
+  GURL foo_url = GURL("http://foo.com");
+  GURL bar_url = GURL("http://bar.com");
+
+  EXPECT_FALSE(prerender_dispatcher_.IsPrerenderURL(foo_url));
+  EXPECT_FALSE(prerender_dispatcher_.IsPrerenderURL(bar_url));
+  prerender_dispatcher_.OnAddPrerenderURL(foo_url);
+  EXPECT_TRUE(prerender_dispatcher_.IsPrerenderURL(foo_url));
+  EXPECT_FALSE(prerender_dispatcher_.IsPrerenderURL(bar_url));
+
+  {
+    prerender_dispatcher_.OnAddPrerenderURL(foo_url);
+    EXPECT_TRUE(prerender_dispatcher_.IsPrerenderURL(foo_url));
+    EXPECT_FALSE(prerender_dispatcher_.IsPrerenderURL(bar_url));
+    PrerenderDispatcher::PrerenderMap::const_iterator foo_entry =
+        prerender_dispatcher_.prerender_urls_.find(foo_url);

[gavinp, 2012/05/24 15:58:56]

I don't like these automatics, and the scope they require us to make.  But I see
that we want to deref the element.  I propose:

if (prerender_urls().count(foo_url) == 1)
  EXPECT_EQ(2, prerender_urls().find(foo_url)->second);
else
  ADD_FAILURE() << "prerender_urls().count(foo_url) != 1";

+    EXPECT_FALSE(prerender_dispatcher_.prerender_urls_.end() == foo_entry);

[gavinp, 2012/05/24 15:58:56]

While we're here, how about we:

EXPECT_EQ(0, prerender_dispatcher_.prerender_urls_.count(bar_url));

and again on most of our other calls to map<>::find()?

+    EXPECT_EQ(2, foo_entry->second);
+  }
+
+  {
+    prerender_dispatcher_.OnAddPrerenderURL(bar_url);
+    EXPECT_TRUE(prerender_dispatcher_.IsPrerenderURL(foo_url));
+    EXPECT_TRUE(prerender_dispatcher_.IsPrerenderURL(bar_url));
+    PrerenderDispatcher::PrerenderMap::const_iterator foo_entry =
+        prerender_dispatcher_.prerender_urls_.find(foo_url);
+    EXPECT_FALSE(prerender_dispatcher_.prerender_urls_.end() == foo_entry);
+    EXPECT_EQ(2, foo_entry->second);
+    PrerenderDispatcher::PrerenderMap::const_iterator bar_entry =
+        prerender_dispatcher_.prerender_urls_.find(bar_url);
+    EXPECT_FALSE(prerender_dispatcher_.prerender_urls_.end() == bar_entry);
+    EXPECT_EQ(1, bar_entry->second);
+  }
+}
+
+TEST_F(PrerenderDispatcherTest, PrerenderDispatcherSingleRemove) {
+  GURL foo_url = GURL("http://foo.com");
+  EXPECT_FALSE(prerender_dispatcher_.IsPrerenderURL(foo_url));
+  prerender_dispatcher_.OnAddPrerenderURL(foo_url);
+  EXPECT_TRUE(prerender_dispatcher_.IsPrerenderURL(foo_url));
+  prerender_dispatcher_.OnRemovePrerenderURL(foo_url);
+  EXPECT_FALSE(prerender_dispatcher_.IsPrerenderURL(foo_url));
+  PrerenderDispatcher::PrerenderMap::const_iterator foo_entry =
+      prerender_dispatcher_.prerender_urls_.find(foo_url);
+  EXPECT_EQ(prerender_dispatcher_.prerender_urls_.end(), foo_entry);
+}
+
+TEST_F(PrerenderDispatcherTest, PrerenderDispatcherMultipleRemove) {
+  GURL foo_url = GURL("http://foo.com");
+  EXPECT_FALSE(prerender_dispatcher_.IsPrerenderURL(foo_url));
+  prerender_dispatcher_.OnAddPrerenderURL(foo_url);
+  EXPECT_TRUE(prerender_dispatcher_.IsPrerenderURL(foo_url));
+  prerender_dispatcher_.OnAddPrerenderURL(foo_url);
+  EXPECT_TRUE(prerender_dispatcher_.IsPrerenderURL(foo_url));
+  PrerenderDispatcher::PrerenderMap::const_iterator foo_entry =
+      prerender_dispatcher_.prerender_urls_.find(foo_url);
+  EXPECT_FALSE(prerender_dispatcher_.prerender_urls_.end() == foo_entry);
+  EXPECT_EQ(2, foo_entry->second);
+
+  prerender_dispatcher_.OnRemovePrerenderURL(foo_url);
+  EXPECT_TRUE(prerender_dispatcher_.IsPrerenderURL(foo_url));
+  foo_entry = prerender_dispatcher_.prerender_urls_.find(foo_url);
+  EXPECT_FALSE(prerender_dispatcher_.prerender_urls_.end() == foo_entry);
+  EXPECT_EQ(1, foo_entry->second);
+
+  prerender_dispatcher_.OnRemovePrerenderURL(foo_url);
+  EXPECT_FALSE(prerender_dispatcher_.IsPrerenderURL(foo_url));
+  foo_entry = prerender_dispatcher_.prerender_urls_.find(foo_url);
+  EXPECT_EQ(prerender_dispatcher_.prerender_urls_.end(), foo_entry);
+}
+
+}  // end namespace prerender

[gavinp, 2012/05/24 15:58:56]

Nit: // namespace prerender