Issue 10423010: Applying release settings to Release_Base rather than just Release.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10423010: Applying release settings to Release_Base rather than just Release. (Closed)

Created:
8 years, 7 months ago by bradn

Modified:
8 years, 6 months ago

Reviewers:
Brad Chen (chromium), M-A Ruel, Brad Chen

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Applying release settings to Release_Base rather than just Release. This ensures that both 32-bit and 64-bit windows executables get release settings (like 'defines': ['OFFICIAL_BUILD']). BUG=http://code.google.com/p/chromium/issues/detail?id=129372 TEST=None R=bradchen@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138613

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
	M	build/common.gypi	View		2 chunks	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/10423010/1

8 years, 7 months ago (2012-05-23 18:11:24 UTC) #3

lgtm

Expand Messages | Collapse Messages