Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 10423006: Remove the web-ui task manager unused stuffs for non-ChromeOS. (Closed)

Created:
8 years, 7 months ago by yoshiki
Modified:
8 years, 6 months ago
Reviewers:
mazda, sky
CC:
chromium-reviews, jennb, yoshiki+watch_chromium.org, Dmitry Titov, jianli, dcheng, Andrei
Visibility:
Public.

Description

Remove the web-ui task manager unused stuffs for non-ChromeOS. This CL removes the task manager stuffs for non-ChromeOS, which are used to support web ui task manager for Win (non-aura), Mac and Linux. BUG=129285 TEST=manual, trybot passes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139822

Patch Set 1 #

Total comments: 5

Patch Set 2 : sync #

Patch Set 3 : Remove "webui_task_manager" and use "use_aura" instead. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -127 lines) Patch
M build/common.gypi View 1 2 5 chunks +0 lines, -15 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 2 2 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest_util.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 2 2 chunks +2 lines, -21 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 2 2 chunks +2 lines, -21 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_window_cocoa.mm View 1 2 2 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 chunks +10 lines, -17 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/task_manager/task_manager_dialog.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/task_manager/task_manager_dialog.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
yoshiki
mazda: could you take a look? sky: could you approve this CL?
8 years, 7 months ago (2012-05-26 00:39:31 UTC) #1
mazda
http://codereview.chromium.org/10423006/diff/1/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): http://codereview.chromium.org/10423006/diff/1/chrome/chrome_browser.gypi#newcode4099 chrome/chrome_browser.gypi:4099: ['enable_task_manager==0', { Is this variable still necessary? How about ...
8 years, 7 months ago (2012-05-26 04:00:06 UTC) #2
yoshiki
http://codereview.chromium.org/10423006/diff/1/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): http://codereview.chromium.org/10423006/diff/1/chrome/chrome_browser.gypi#newcode4099 chrome/chrome_browser.gypi:4099: ['enable_task_manager==0', { I don't know much about "enable_task_manager". As ...
8 years, 7 months ago (2012-05-28 06:04:02 UTC) #3
mazda
http://codereview.chromium.org/10423006/diff/1/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): http://codereview.chromium.org/10423006/diff/1/chrome/chrome_browser.gypi#newcode4099 chrome/chrome_browser.gypi:4099: ['enable_task_manager==0', { On 2012/05/28 06:04:03, yoshiki wrote: > I ...
8 years, 6 months ago (2012-05-29 17:28:06 UTC) #4
yoshiki
mazda: PTAL? https://chromiumcodereview.appspot.com/10423006/diff/1/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://chromiumcodereview.appspot.com/10423006/diff/1/chrome/chrome_browser.gypi#newcode4099 chrome/chrome_browser.gypi:4099: ['enable_task_manager==0', { On 2012/05/29 17:28:06, mazda wrote: ...
8 years, 6 months ago (2012-05-31 06:58:51 UTC) #5
mazda
lgtm
8 years, 6 months ago (2012-05-31 07:14:38 UTC) #6
yoshiki
sky: could you take a look and approve it? mazda: thank you for review!
8 years, 6 months ago (2012-05-31 07:50:34 UTC) #7
sky
LGTM
8 years, 6 months ago (2012-05-31 15:02:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/10423006/10020
8 years, 6 months ago (2012-05-31 16:33:22 UTC) #9
commit-bot: I haz the power
8 years, 6 months ago (2012-05-31 18:15:52 UTC) #10
Change committed as 139822

Powered by Google App Engine
This is Rietveld 408576698