Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 10422006: Change rietveld object to use new URL to download binary files. This depnds (Closed)

Created:
8 years, 7 months ago by Roger Tawa OOO till Jul 10th
Modified:
8 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

Change rietveld object to use new URL to download binary files. This depnds on http://codereview.appspot.com/6221063/ which makes sure that rietveld will upload non-image binary files. BUG=23608 TEST=Use apply_issue.py with an issue that contains binary files, and make sure the files download correctly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138472

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M rietveld.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Roger Tawa OOO till Jul 10th
8 years, 7 months ago (2012-05-22 20:38:45 UTC) #1
M-A Ruel
lgtm, I don't think there's a test for this but it's not a big deal.
8 years, 7 months ago (2012-05-22 20:56:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/10422006/1
8 years, 7 months ago (2012-05-23 14:43:23 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-23 14:51:00 UTC) #4
Change committed as 138472

Powered by Google App Engine
This is Rietveld 408576698