ppapi/cpp/dev/ime_input_event_dev.cc - Issue 10421032: Coverity: Fix pass by value error in IMEInputEvent_Dev.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/cpp/dev/ime_input_event_dev.cc

Issue 10421032: Coverity: Fix pass by value error in IMEInputEvent_Dev. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/cpp/dev/ime_input_event_dev.cc

diff --git a/ppapi/cpp/dev/ime_input_event_dev.cc b/ppapi/cpp/dev/ime_input_event_dev.cc

index 99fe66d8a742563ad77b7ee4260b12eaa73147b5..9ddc16e913881cfe2f0247dfdb12552150ddac69 100644

--- a/ppapi/cpp/dev/ime_input_event_dev.cc

+++ b/ppapi/cpp/dev/ime_input_event_dev.cc

@@ -52,7 +52,7 @@ IMEInputEvent_Dev::IMEInputEvent_Dev(

const InstanceHandle& instance,

PP_InputEvent_Type type,

PP_TimeTicks time_stamp,

- Var text,

+ const Var& text,

const std::vector<uint32_t>& segment_offsets,

int32_t target_segment,

const std::pair<uint32_t, uint32_t>& selection) : InputEvent() {

« no previous file with comments | « ppapi/cpp/dev/ime_input_event_dev.h ('k') | no next file » | no next file with comments »