Make pub handle missing git more gracefully.

utils/pub/pub.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * The main entrypoint for the pub command line application.
  */
 #library('pub');
 
 #import('io.dart');
@@ skipping 61 matching lines @@
   }
 
   var cache = new SystemCache(cacheDir);
   cache.sources.register(new SdkSource(sdkDir));
   cache.sources.register(new GitSource());
   cache.sources.setDefault('sdk');
 
   // Select the command.
   var command = commands[args[0]];
   if (command == null) {
-    print('Unknown command "${args[0]}".');
-    print('Run "pub help" to see available commands.');
+    printError('Unknown command "${args[0]}".');
+    printError('Run "pub help" to see available commands.');
     exit(64); // See http://www.freebsd.org/cgi/man.cgi?query=sysexits.
     return;
   }
 
   args.removeRange(0, 1);
   command.run(cache, args);
 }
 
 /** Displays usage information for the app. */
 void printUsage(Map<String, PubCommand> commands) {
@@ skipping 38 matching lines @@
 
   void run(SystemCache cache_, List<String> args) {
     cache = cache_;
 
     // TODO(rnystrom): Each command should define the arguments it expects and
     // we can handle them generically here.
 
     // TODO(rnystrom): Will eventually need better logic to walk up
     // subdirectories until we hit one that looks package-like. For now, just
     // assume the cwd is it.
-    Package.load(workingDir, cache.sources).then((package) {
+    var future = Package.load(workingDir, cache.sources).chain((package) {

[nweiz, 2012/05/23 00:46:26]

No reason to assign this future to a var; you can just call handleException
directly.

[Bob Nystrom, 2012/05/23 16:32:33]

Done.

       entrypoint = new Entrypoint(package, cache);
-      onRun();
+      var commandFuture = onRun();
+      if (commandFuture == null) return new Future.immediate(true);
+
+      return commandFuture;
+    });
+
+    // This is basically the top-level exception handler so that we don't
+    // spew a stack trace on our users.
+    future.handleException((error) {
+      var message = error.toString();

[nweiz, 2012/05/23 00:46:26]

We should probably have a --trace flag or something similar to force a stack
trace when debugging.

[Bob Nystrom, 2012/05/23 16:32:33]

Added TODO.

+
+      // TODO(rnystrom): The default exception implementation class puts
+      // "Exception:" in the output, so strip that off.
+      if (message.startsWith("Exception: ")) {
+        message = message.substring("Exception: ".length);
+      }
+
+      printError(message);
+      return true;
     });
   }
 
-  abstract void onRun();
+  /**
+   * Override this to perform the specific command. Return a future that
+   * completes when the command is done or fails if the command fails. If the
+   * command is synchronous, it may return `null`.

[nweiz, 2012/05/23 00:46:26]

What if a synchronous command has an error?

[Bob Nystrom, 2012/05/23 16:32:33]

Good call. Added try block around onRun().

+   */
+  abstract Future onRun();
 }