Issue 10421010: Revert 138278 - Fix the volume controlling behaviors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10421010: Revert 138278 - Fix the volume controlling behaviors. (Closed)

Created:
8 years, 7 months ago by Ian Vollick

Modified:
8 years, 7 months ago

Reviewers:
Jun Mukai

CC:
chromium-reviews, sadrul, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 138278 - Fix the volume controlling behaviors. Based on the description of crbug.com/128644: - volume up from muted should be normal up (4%), not 25% - but if the volume up happens after the mute button, it should go back to the original volume BUG=128644 TEST=browser_test passed, manually checked on lumpy Review URL: https://chromiumcodereview.appspot.com/10411028 TBR=mukai@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138299

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -179 lines)			Patch
M	chrome/browser/chromeos/audio/audio_handler.h	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/browser/chromeos/audio/audio_handler.cc	View	3 chunks	+7 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/views/ash/volume_controller_chromeos.cc	View	2 chunks	+7 lines, -5 lines	0 comments	Download
D	chrome/browser/ui/views/ash/volume_controller_chromeos_browsertest.cc	View	1 chunk	+0 lines, -154 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)