Issue 10417036: Remove BrowserList usage from autofill CC infobar delegate, replacing it with using content api dir…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10417036: Remove BrowserList usage from autofill CC infobar delegate, replacing it with using content api dir… (Closed)

Created:
8 years, 7 months ago by Ben Goodger (Google)

Modified:
8 years, 7 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, dhollowa+watch_chromium.org, Ilya Sherman, dyu1, Yaron

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Remove BrowserList usage from autofill CC infobar delegate, replacing it with using content api directly to open a tab in the relevant context. This also allows us to remove some cruft from Browser. http://crbug.com/129187 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138379

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -17 lines)			Patch
M	chrome/browser/autofill/autofill_cc_infobar_delegate.cc	View	2 chunks	+12 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/browser.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

Ben Goodger (Google)

This allows us to get rid of an OS_ANDROID ifdef, since this code will "just ...

8 years, 7 months ago (2012-05-22 18:30:58 UTC) #1

LGTM, thanks